* PATCH: revert find_pc_sect_line sanity check
@ 2001-11-26 16:04 Jim Blandy
2001-11-13 9:11 ` Jim Blandy
2001-11-13 9:18 ` Daniel Jacobowitz
0 siblings, 2 replies; 6+ messages in thread
From: Jim Blandy @ 2001-11-26 16:04 UTC (permalink / raw)
To: gdb-patches
2001-11-26 Jim Blandy <jimb@redhat.com>
* symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
comment explaining that hand-written assembly code can have line
number info but no debug info for an enclosing function.
Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.48
diff -c -c -b -F'^(' -r1.48 symtab.c
*** symtab.c 2001/11/13 16:42:50 1.48
--- symtab.c 2001/11/26 23:58:08
***************
*** 1570,1582 ****
INIT_SAL (&val); /* initialize to zeroes */
! /* Don't even think about line numbers if we can't find a function
! symbol for PC. */
! if (find_pc_function (pc) == NULL)
! {
! val.pc = pc;
! return val;
! }
if (notcurrent)
pc -= 1;
--- 1570,1581 ----
INIT_SAL (&val); /* initialize to zeroes */
! /* It's tempting to assume that, if we can't find debugging info for
! any function enclosing PC, that we shouldn't search for line
! number info, either. However, GAS can emit line number info for
! assembly files --- very helpful when debugging hand-written
! assembly code. In such a case, we'd have no debug info for the
! function, but we would have line info. */
if (notcurrent)
pc -= 1;
^ permalink raw reply [flat|nested] 6+ messages in thread* PATCH: revert find_pc_sect_line sanity check
2001-11-26 16:04 PATCH: revert find_pc_sect_line sanity check Jim Blandy
@ 2001-11-13 9:11 ` Jim Blandy
2001-11-13 9:18 ` Daniel Jacobowitz
1 sibling, 0 replies; 6+ messages in thread
From: Jim Blandy @ 2001-11-13 9:11 UTC (permalink / raw)
To: gdb-patches
2001-11-26 Jim Blandy <jimb@redhat.com>
* symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
comment explaining that hand-written assembly code can have line
number info but no debug info for an enclosing function.
Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.48
diff -c -c -b -F'^(' -r1.48 symtab.c
*** symtab.c 2001/11/13 16:42:50 1.48
--- symtab.c 2001/11/26 23:58:08
***************
*** 1570,1582 ****
INIT_SAL (&val); /* initialize to zeroes */
! /* Don't even think about line numbers if we can't find a function
! symbol for PC. */
! if (find_pc_function (pc) == NULL)
! {
! val.pc = pc;
! return val;
! }
if (notcurrent)
pc -= 1;
--- 1570,1581 ----
INIT_SAL (&val); /* initialize to zeroes */
! /* It's tempting to assume that, if we can't find debugging info for
! any function enclosing PC, that we shouldn't search for line
! number info, either. However, GAS can emit line number info for
! assembly files --- very helpful when debugging hand-written
! assembly code. In such a case, we'd have no debug info for the
! function, but we would have line info. */
if (notcurrent)
pc -= 1;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: PATCH: revert find_pc_sect_line sanity check
2001-11-26 16:04 PATCH: revert find_pc_sect_line sanity check Jim Blandy
2001-11-13 9:11 ` Jim Blandy
@ 2001-11-13 9:18 ` Daniel Jacobowitz
2001-11-13 14:32 ` Jim Blandy
2001-11-26 16:07 ` Daniel Jacobowitz
1 sibling, 2 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2001-11-13 9:18 UTC (permalink / raw)
To: gdb-patches
On Mon, Nov 26, 2001 at 07:05:38PM -0500, Jim Blandy wrote:
>
> 2001-11-26 Jim Blandy <jimb@redhat.com>
>
> * symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
> comment explaining that hand-written assembly code can have line
> number info but no debug info for an enclosing function.
Great. Meanwhile, I've had several ideas how to get the address range
information out, even from stabs. How's the DWARF2 side of it coming
along?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH: revert find_pc_sect_line sanity check
2001-11-13 9:18 ` Daniel Jacobowitz
@ 2001-11-13 14:32 ` Jim Blandy
2001-11-26 20:12 ` Jim Blandy
2001-11-26 16:07 ` Daniel Jacobowitz
1 sibling, 1 reply; 6+ messages in thread
From: Jim Blandy @ 2001-11-13 14:32 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
Daniel Jacobowitz <drow@mvista.com> writes:
> On Mon, Nov 26, 2001 at 07:05:38PM -0500, Jim Blandy wrote:
> >
> > 2001-11-26 Jim Blandy <jimb@redhat.com>
> >
> > * symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
> > comment explaining that hand-written assembly code can have line
> > number info but no debug info for an enclosing function.
>
> Great. Meanwhile, I've had several ideas how to get the address range
> information out, even from stabs. How's the DWARF2 side of it coming
> along?
Haven't had time to work on this at all. :( I may have some in
December.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH: revert find_pc_sect_line sanity check
2001-11-13 14:32 ` Jim Blandy
@ 2001-11-26 20:12 ` Jim Blandy
0 siblings, 0 replies; 6+ messages in thread
From: Jim Blandy @ 2001-11-26 20:12 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
Daniel Jacobowitz <drow@mvista.com> writes:
> On Mon, Nov 26, 2001 at 07:05:38PM -0500, Jim Blandy wrote:
> >
> > 2001-11-26 Jim Blandy <jimb@redhat.com>
> >
> > * symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
> > comment explaining that hand-written assembly code can have line
> > number info but no debug info for an enclosing function.
>
> Great. Meanwhile, I've had several ideas how to get the address range
> information out, even from stabs. How's the DWARF2 side of it coming
> along?
Haven't had time to work on this at all. :( I may have some in
December.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH: revert find_pc_sect_line sanity check
2001-11-13 9:18 ` Daniel Jacobowitz
2001-11-13 14:32 ` Jim Blandy
@ 2001-11-26 16:07 ` Daniel Jacobowitz
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2001-11-26 16:07 UTC (permalink / raw)
To: gdb-patches
On Mon, Nov 26, 2001 at 07:05:38PM -0500, Jim Blandy wrote:
>
> 2001-11-26 Jim Blandy <jimb@redhat.com>
>
> * symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
> comment explaining that hand-written assembly code can have line
> number info but no debug info for an enclosing function.
Great. Meanwhile, I've had several ideas how to get the address range
information out, even from stabs. How's the DWARF2 side of it coming
along?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-11-27 4:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-11-26 16:04 PATCH: revert find_pc_sect_line sanity check Jim Blandy
2001-11-13 9:11 ` Jim Blandy
2001-11-13 9:18 ` Daniel Jacobowitz
2001-11-13 14:32 ` Jim Blandy
2001-11-26 20:12 ` Jim Blandy
2001-11-26 16:07 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox