Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@zwingli.cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: PATCH: revert find_pc_sect_line sanity check
Date: Mon, 26 Nov 2001 16:04:00 -0000	[thread overview]
Message-ID: <20011127000538.68E465E9D8@zwingli.cygnus.com> (raw)

2001-11-26  Jim Blandy  <jimb@redhat.com>

	* symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
	comment explaining that hand-written assembly code can have line
	number info but no debug info for an enclosing function.

Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.48
diff -c -c -b -F'^(' -r1.48 symtab.c
*** symtab.c	2001/11/13 16:42:50	1.48
--- symtab.c	2001/11/26 23:58:08
***************
*** 1570,1582 ****
  
    INIT_SAL (&val);		/* initialize to zeroes */
  
!   /* Don't even think about line numbers if we can't find a function
!      symbol for PC.  */
!   if (find_pc_function (pc) == NULL)
!     {
!       val.pc = pc;
!       return val;
!     }
  
    if (notcurrent)
      pc -= 1;
--- 1570,1581 ----
  
    INIT_SAL (&val);		/* initialize to zeroes */
  
!   /* It's tempting to assume that, if we can't find debugging info for
!      any function enclosing PC, that we shouldn't search for line
!      number info, either.  However, GAS can emit line number info for
!      assembly files --- very helpful when debugging hand-written
!      assembly code.  In such a case, we'd have no debug info for the
!      function, but we would have line info.  */
  
    if (notcurrent)
      pc -= 1;


WARNING: multiple messages have this Message-ID
From: Jim Blandy <jimb@zwingli.cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: PATCH: revert find_pc_sect_line sanity check
Date: Tue, 13 Nov 2001 09:11:00 -0000	[thread overview]
Message-ID: <20011127000538.68E465E9D8@zwingli.cygnus.com> (raw)
Message-ID: <20011113091100.0zkMb9Q7yldsnL9tjUDudhjhjjI-sc24IYapkyREyDk@z> (raw)


2001-11-26  Jim Blandy  <jimb@redhat.com>

	* symtab.c (find_pc_sect_line): Revert change of 2001-11-13; add
	comment explaining that hand-written assembly code can have line
	number info but no debug info for an enclosing function.

Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.48
diff -c -c -b -F'^(' -r1.48 symtab.c
*** symtab.c	2001/11/13 16:42:50	1.48
--- symtab.c	2001/11/26 23:58:08
***************
*** 1570,1582 ****
  
    INIT_SAL (&val);		/* initialize to zeroes */
  
!   /* Don't even think about line numbers if we can't find a function
!      symbol for PC.  */
!   if (find_pc_function (pc) == NULL)
!     {
!       val.pc = pc;
!       return val;
!     }
  
    if (notcurrent)
      pc -= 1;
--- 1570,1581 ----
  
    INIT_SAL (&val);		/* initialize to zeroes */
  
!   /* It's tempting to assume that, if we can't find debugging info for
!      any function enclosing PC, that we shouldn't search for line
!      number info, either.  However, GAS can emit line number info for
!      assembly files --- very helpful when debugging hand-written
!      assembly code.  In such a case, we'd have no debug info for the
!      function, but we would have line info.  */
  
    if (notcurrent)
      pc -= 1;


             reply	other threads:[~2001-11-26 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-26 16:04 Jim Blandy [this message]
2001-11-13  9:11 ` Jim Blandy
2001-11-13  9:18 ` Daniel Jacobowitz
2001-11-13 14:32   ` Jim Blandy
2001-11-26 20:12     ` Jim Blandy
2001-11-26 16:07   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011127000538.68E465E9D8@zwingli.cygnus.com \
    --to=jimb@zwingli.cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox