* [RFA/testsuite] Fix linux-dp failure for multiple targets
@ 2002-01-09 15:38 Daniel Jacobowitz
2002-01-29 21:57 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2002-01-09 15:38 UTC (permalink / raw)
To: gdb-patches
Two things I noticed in my testsuite runs. We were never finding the
manager thread, and in gcc3 (which apparently unlike GCC2 produces reliable
and stable addresses for the data pointers; I don't know why...) the second
target board to run would find the old value of the seen array. 'array set'
doesn't do what the author of the testcase expected.
Is this OK?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2002-01-09 Daniel Jacobowitz <drow@mvista.com>
* gdb.threads/linux-dp.exp: Use 'array unset', not 'array set'.
(check_philosopher_stack): Check for manager thread before checking
for a just-starting thread.
Index: linux-dp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
retrieving revision 1.4
diff -u -p -r1.4 linux-dp.exp
--- linux-dp.exp 2001/05/25 01:29:01 1.4
+++ linux-dp.exp 2002/01/09 23:35:01
@@ -172,6 +172,15 @@ proc check_philosopher_stack {thread see
}
set interesting 1
}
+ -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
+ if {$manager_seen == 1} {
+ fail "manager thread is distinct: $thread"
+ } else {
+ set manager_seen 1
+ pass "manager thread is distinct: $thread"
+ }
+ set interesting 1
+ }
-re "pthread_start_thread.*\r\n$gdb_prompt $" {
## Maybe the thread hasn't started yet.
pass $name
@@ -185,15 +194,6 @@ proc check_philosopher_stack {thread see
}
set interesting 1
}
- -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
- if {$manager_seen == 1} {
- fail "manager thread is distinct: $thread"
- } else {
- set manager_seen 1
- pass "manager thread is distinct: $thread"
- }
- set interesting 1
- }
-re " in \\?\\?.*\r\n$gdb_prompt $" {
## Sometimes we can't get a backtrace. I'm going to call
## this a pass, since we do verify that at least one
@@ -214,7 +214,7 @@ proc check_philosopher_stack {thread see
}
set any_interesting 0
-array set seen {}
+array unset seen
for {set i 1} {$i <= 7} {incr i} {
if [check_philosopher_stack $i seen] {
set any_interesting 1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/testsuite] Fix linux-dp failure for multiple targets
2002-01-09 15:38 [RFA/testsuite] Fix linux-dp failure for multiple targets Daniel Jacobowitz
@ 2002-01-29 21:57 ` Daniel Jacobowitz
2002-01-30 7:04 ` Fernando Nasser
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2002-01-29 21:57 UTC (permalink / raw)
To: gdb-patches
On Wed, Jan 09, 2002 at 06:39:26PM -0500, Daniel Jacobowitz wrote:
> Two things I noticed in my testsuite runs. We were never finding the
> manager thread, and in gcc3 (which apparently unlike GCC2 produces reliable
> and stable addresses for the data pointers; I don't know why...) the second
> target board to run would find the old value of the seen array. 'array set'
> doesn't do what the author of the testcase expected.
>
> Is this OK?
I'd appreciate it if someone would review this.
> 2002-01-09 Daniel Jacobowitz <drow@mvista.com>
>
> * gdb.threads/linux-dp.exp: Use 'array unset', not 'array set'.
> (check_philosopher_stack): Check for manager thread before checking
> for a just-starting thread.
>
> Index: linux-dp.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
> retrieving revision 1.4
> diff -u -p -r1.4 linux-dp.exp
> --- linux-dp.exp 2001/05/25 01:29:01 1.4
> +++ linux-dp.exp 2002/01/09 23:35:01
> @@ -172,6 +172,15 @@ proc check_philosopher_stack {thread see
> }
> set interesting 1
> }
> + -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> + if {$manager_seen == 1} {
> + fail "manager thread is distinct: $thread"
> + } else {
> + set manager_seen 1
> + pass "manager thread is distinct: $thread"
> + }
> + set interesting 1
> + }
> -re "pthread_start_thread.*\r\n$gdb_prompt $" {
> ## Maybe the thread hasn't started yet.
> pass $name
> @@ -185,15 +194,6 @@ proc check_philosopher_stack {thread see
> }
> set interesting 1
> }
> - -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> - if {$manager_seen == 1} {
> - fail "manager thread is distinct: $thread"
> - } else {
> - set manager_seen 1
> - pass "manager thread is distinct: $thread"
> - }
> - set interesting 1
> - }
> -re " in \\?\\?.*\r\n$gdb_prompt $" {
> ## Sometimes we can't get a backtrace. I'm going to call
> ## this a pass, since we do verify that at least one
> @@ -214,7 +214,7 @@ proc check_philosopher_stack {thread see
> }
>
> set any_interesting 0
> -array set seen {}
> +array unset seen
> for {set i 1} {$i <= 7} {incr i} {
> if [check_philosopher_stack $i seen] {
> set any_interesting 1
>
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/testsuite] Fix linux-dp failure for multiple targets
2002-01-29 21:57 ` Daniel Jacobowitz
@ 2002-01-30 7:04 ` Fernando Nasser
2002-01-30 11:07 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Fernando Nasser @ 2002-01-30 7:04 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches, Michael Snyder
Daniel Jacobowitz wrote:
>
> On Wed, Jan 09, 2002 at 06:39:26PM -0500, Daniel Jacobowitz wrote:
> > Two things I noticed in my testsuite runs. We were never finding the
> > manager thread, and in gcc3 (which apparently unlike GCC2 produces reliable
> > and stable addresses for the data pointers; I don't know why...) the second
> > target board to run would find the old value of the seen array. 'array set'
> > doesn't do what the author of the testcase expected.
> >
> > Is this OK?
>
> I'd appreciate it if someone would review this.
>
Michael Snyder has the final word on this one.
I don't have any objections.
Fernando
> > 2002-01-09 Daniel Jacobowitz <drow@mvista.com>
> >
> > * gdb.threads/linux-dp.exp: Use 'array unset', not 'array set'.
> > (check_philosopher_stack): Check for manager thread before checking
> > for a just-starting thread.
> >
> > Index: linux-dp.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
> > retrieving revision 1.4
> > diff -u -p -r1.4 linux-dp.exp
> > --- linux-dp.exp 2001/05/25 01:29:01 1.4
> > +++ linux-dp.exp 2002/01/09 23:35:01
> > @@ -172,6 +172,15 @@ proc check_philosopher_stack {thread see
> > }
> > set interesting 1
> > }
> > + -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > + if {$manager_seen == 1} {
> > + fail "manager thread is distinct: $thread"
> > + } else {
> > + set manager_seen 1
> > + pass "manager thread is distinct: $thread"
> > + }
> > + set interesting 1
> > + }
> > -re "pthread_start_thread.*\r\n$gdb_prompt $" {
> > ## Maybe the thread hasn't started yet.
> > pass $name
> > @@ -185,15 +194,6 @@ proc check_philosopher_stack {thread see
> > }
> > set interesting 1
> > }
> > - -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > - if {$manager_seen == 1} {
> > - fail "manager thread is distinct: $thread"
> > - } else {
> > - set manager_seen 1
> > - pass "manager thread is distinct: $thread"
> > - }
> > - set interesting 1
> > - }
> > -re " in \\?\\?.*\r\n$gdb_prompt $" {
> > ## Sometimes we can't get a backtrace. I'm going to call
> > ## this a pass, since we do verify that at least one
> > @@ -214,7 +214,7 @@ proc check_philosopher_stack {thread see
> > }
> >
> > set any_interesting 0
> > -array set seen {}
> > +array unset seen
> > for {set i 1} {$i <= 7} {incr i} {
> > if [check_philosopher_stack $i seen] {
> > set any_interesting 1
> >
>
> --
> Daniel Jacobowitz Carnegie Mellon University
> MontaVista Software Debian GNU/Linux Developer
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/testsuite] Fix linux-dp failure for multiple targets
2002-01-30 7:04 ` Fernando Nasser
@ 2002-01-30 11:07 ` Michael Snyder
2002-01-30 14:19 ` Jim Blandy
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2002-01-30 11:07 UTC (permalink / raw)
To: Fernando Nasser; +Cc: Daniel Jacobowitz, gdb-patches, jimb
Fernando Nasser wrote:
>
> Daniel Jacobowitz wrote:
> >
> > On Wed, Jan 09, 2002 at 06:39:26PM -0500, Daniel Jacobowitz wrote:
> > > Two things I noticed in my testsuite runs. We were never finding the
> > > manager thread, and in gcc3 (which apparently unlike GCC2 produces reliable
> > > and stable addresses for the data pointers; I don't know why...) the second
> > > target board to run would find the old value of the seen array. 'array set'
> > > doesn't do what the author of the testcase expected.
> > >
> > > Is this OK?
> >
> > I'd appreciate it if someone would review this.
> >
>
> Michael Snyder has the final word on this one.
Actually Jim Blandy is the author of this test.
>
> I don't have any objections.
>
> Fernando
>
> > > 2002-01-09 Daniel Jacobowitz <drow@mvista.com>
> > >
> > > * gdb.threads/linux-dp.exp: Use 'array unset', not 'array set'.
> > > (check_philosopher_stack): Check for manager thread before checking
> > > for a just-starting thread.
> > >
> > > Index: linux-dp.exp
> > > ===================================================================
> > > RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
> > > retrieving revision 1.4
> > > diff -u -p -r1.4 linux-dp.exp
> > > --- linux-dp.exp 2001/05/25 01:29:01 1.4
> > > +++ linux-dp.exp 2002/01/09 23:35:01
> > > @@ -172,6 +172,15 @@ proc check_philosopher_stack {thread see
> > > }
> > > set interesting 1
> > > }
> > > + -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > > + if {$manager_seen == 1} {
> > > + fail "manager thread is distinct: $thread"
> > > + } else {
> > > + set manager_seen 1
> > > + pass "manager thread is distinct: $thread"
> > > + }
> > > + set interesting 1
> > > + }
> > > -re "pthread_start_thread.*\r\n$gdb_prompt $" {
> > > ## Maybe the thread hasn't started yet.
> > > pass $name
> > > @@ -185,15 +194,6 @@ proc check_philosopher_stack {thread see
> > > }
> > > set interesting 1
> > > }
> > > - -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > > - if {$manager_seen == 1} {
> > > - fail "manager thread is distinct: $thread"
> > > - } else {
> > > - set manager_seen 1
> > > - pass "manager thread is distinct: $thread"
> > > - }
> > > - set interesting 1
> > > - }
> > > -re " in \\?\\?.*\r\n$gdb_prompt $" {
> > > ## Sometimes we can't get a backtrace. I'm going to call
> > > ## this a pass, since we do verify that at least one
> > > @@ -214,7 +214,7 @@ proc check_philosopher_stack {thread see
> > > }
> > >
> > > set any_interesting 0
> > > -array set seen {}
> > > +array unset seen
> > > for {set i 1} {$i <= 7} {incr i} {
> > > if [check_philosopher_stack $i seen] {
> > > set any_interesting 1
> > >
> >
> > --
> > Daniel Jacobowitz Carnegie Mellon University
> > MontaVista Software Debian GNU/Linux Developer
>
> --
> Fernando Nasser
> Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/testsuite] Fix linux-dp failure for multiple targets
2002-01-30 11:07 ` Michael Snyder
@ 2002-01-30 14:19 ` Jim Blandy
2002-01-30 21:06 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Jim Blandy @ 2002-01-30 14:19 UTC (permalink / raw)
To: Michael Snyder; +Cc: Fernando Nasser, Daniel Jacobowitz, gdb-patches
I approve this change.
Michael Snyder <msnyder@redhat.com> writes:
> Fernando Nasser wrote:
> >
> > Daniel Jacobowitz wrote:
> > >
> > > On Wed, Jan 09, 2002 at 06:39:26PM -0500, Daniel Jacobowitz wrote:
> > > > Two things I noticed in my testsuite runs. We were never finding the
> > > > manager thread, and in gcc3 (which apparently unlike GCC2 produces reliable
> > > > and stable addresses for the data pointers; I don't know why...) the second
> > > > target board to run would find the old value of the seen array. 'array set'
> > > > doesn't do what the author of the testcase expected.
> > > >
> > > > Is this OK?
> > >
> > > I'd appreciate it if someone would review this.
> > >
> >
> > Michael Snyder has the final word on this one.
>
> Actually Jim Blandy is the author of this test.
>
> >
> > I don't have any objections.
> >
> > Fernando
> >
> > > > 2002-01-09 Daniel Jacobowitz <drow@mvista.com>
> > > >
> > > > * gdb.threads/linux-dp.exp: Use 'array unset', not 'array set'.
> > > > (check_philosopher_stack): Check for manager thread before checking
> > > > for a just-starting thread.
> > > >
> > > > Index: linux-dp.exp
> > > > ===================================================================
> > > > RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
> > > > retrieving revision 1.4
> > > > diff -u -p -r1.4 linux-dp.exp
> > > > --- linux-dp.exp 2001/05/25 01:29:01 1.4
> > > > +++ linux-dp.exp 2002/01/09 23:35:01
> > > > @@ -172,6 +172,15 @@ proc check_philosopher_stack {thread see
> > > > }
> > > > set interesting 1
> > > > }
> > > > + -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > > > + if {$manager_seen == 1} {
> > > > + fail "manager thread is distinct: $thread"
> > > > + } else {
> > > > + set manager_seen 1
> > > > + pass "manager thread is distinct: $thread"
> > > > + }
> > > > + set interesting 1
> > > > + }
> > > > -re "pthread_start_thread.*\r\n$gdb_prompt $" {
> > > > ## Maybe the thread hasn't started yet.
> > > > pass $name
> > > > @@ -185,15 +194,6 @@ proc check_philosopher_stack {thread see
> > > > }
> > > > set interesting 1
> > > > }
> > > > - -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > > > - if {$manager_seen == 1} {
> > > > - fail "manager thread is distinct: $thread"
> > > > - } else {
> > > > - set manager_seen 1
> > > > - pass "manager thread is distinct: $thread"
> > > > - }
> > > > - set interesting 1
> > > > - }
> > > > -re " in \\?\\?.*\r\n$gdb_prompt $" {
> > > > ## Sometimes we can't get a backtrace. I'm going to call
> > > > ## this a pass, since we do verify that at least one
> > > > @@ -214,7 +214,7 @@ proc check_philosopher_stack {thread see
> > > > }
> > > >
> > > > set any_interesting 0
> > > > -array set seen {}
> > > > +array unset seen
> > > > for {set i 1} {$i <= 7} {incr i} {
> > > > if [check_philosopher_stack $i seen] {
> > > > set any_interesting 1
> > > >
> > >
> > > --
> > > Daniel Jacobowitz Carnegie Mellon University
> > > MontaVista Software Debian GNU/Linux Developer
> >
> > --
> > Fernando Nasser
> > Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
> > 2323 Yonge Street, Suite #300
> > Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/testsuite] Fix linux-dp failure for multiple targets
2002-01-30 14:19 ` Jim Blandy
@ 2002-01-30 21:06 ` Daniel Jacobowitz
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2002-01-30 21:06 UTC (permalink / raw)
To: gdb-patches
On Wed, Jan 30, 2002 at 05:20:35PM -0500, Jim Blandy wrote:
>
> I approve this change.
Committed, thanks.
>
> Michael Snyder <msnyder@redhat.com> writes:
>
> > Fernando Nasser wrote:
> > >
> > > Daniel Jacobowitz wrote:
> > > >
> > > > On Wed, Jan 09, 2002 at 06:39:26PM -0500, Daniel Jacobowitz wrote:
> > > > > Two things I noticed in my testsuite runs. We were never finding the
> > > > > manager thread, and in gcc3 (which apparently unlike GCC2 produces reliable
> > > > > and stable addresses for the data pointers; I don't know why...) the second
> > > > > target board to run would find the old value of the seen array. 'array set'
> > > > > doesn't do what the author of the testcase expected.
> > > > >
> > > > > Is this OK?
> > > >
> > > > I'd appreciate it if someone would review this.
> > > >
> > >
> > > Michael Snyder has the final word on this one.
> >
> > Actually Jim Blandy is the author of this test.
> >
> > >
> > > I don't have any objections.
> > >
> > > Fernando
> > >
> > > > > 2002-01-09 Daniel Jacobowitz <drow@mvista.com>
> > > > >
> > > > > * gdb.threads/linux-dp.exp: Use 'array unset', not 'array set'.
> > > > > (check_philosopher_stack): Check for manager thread before checking
> > > > > for a just-starting thread.
> > > > >
> > > > > Index: linux-dp.exp
> > > > > ===================================================================
> > > > > RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
> > > > > retrieving revision 1.4
> > > > > diff -u -p -r1.4 linux-dp.exp
> > > > > --- linux-dp.exp 2001/05/25 01:29:01 1.4
> > > > > +++ linux-dp.exp 2002/01/09 23:35:01
> > > > > @@ -172,6 +172,15 @@ proc check_philosopher_stack {thread see
> > > > > }
> > > > > set interesting 1
> > > > > }
> > > > > + -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > > > > + if {$manager_seen == 1} {
> > > > > + fail "manager thread is distinct: $thread"
> > > > > + } else {
> > > > > + set manager_seen 1
> > > > > + pass "manager thread is distinct: $thread"
> > > > > + }
> > > > > + set interesting 1
> > > > > + }
> > > > > -re "pthread_start_thread.*\r\n$gdb_prompt $" {
> > > > > ## Maybe the thread hasn't started yet.
> > > > > pass $name
> > > > > @@ -185,15 +194,6 @@ proc check_philosopher_stack {thread see
> > > > > }
> > > > > set interesting 1
> > > > > }
> > > > > - -re ".* in __pthread_manager \\(.*$gdb_prompt $" {
> > > > > - if {$manager_seen == 1} {
> > > > > - fail "manager thread is distinct: $thread"
> > > > > - } else {
> > > > > - set manager_seen 1
> > > > > - pass "manager thread is distinct: $thread"
> > > > > - }
> > > > > - set interesting 1
> > > > > - }
> > > > > -re " in \\?\\?.*\r\n$gdb_prompt $" {
> > > > > ## Sometimes we can't get a backtrace. I'm going to call
> > > > > ## this a pass, since we do verify that at least one
> > > > > @@ -214,7 +214,7 @@ proc check_philosopher_stack {thread see
> > > > > }
> > > > >
> > > > > set any_interesting 0
> > > > > -array set seen {}
> > > > > +array unset seen
> > > > > for {set i 1} {$i <= 7} {incr i} {
> > > > > if [check_philosopher_stack $i seen] {
> > > > > set any_interesting 1
> > > > >
> > > >
> > > > --
> > > > Daniel Jacobowitz Carnegie Mellon University
> > > > MontaVista Software Debian GNU/Linux Developer
> > >
> > > --
> > > Fernando Nasser
> > > Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
> > > 2323 Yonge Street, Suite #300
> > > Toronto, Ontario M4P 2C9
>
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-01-31 5:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-09 15:38 [RFA/testsuite] Fix linux-dp failure for multiple targets Daniel Jacobowitz
2002-01-29 21:57 ` Daniel Jacobowitz
2002-01-30 7:04 ` Fernando Nasser
2002-01-30 11:07 ` Michael Snyder
2002-01-30 14:19 ` Jim Blandy
2002-01-30 21:06 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox