Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/testsuite] Fix linux-dp failure for multiple targets
Date: Wed, 09 Jan 2002 15:38:00 -0000	[thread overview]
Message-ID: <20020109183926.A17757@nevyn.them.org> (raw)

Two things I noticed in my testsuite runs.  We were never finding the
manager thread, and in gcc3 (which apparently unlike GCC2 produces reliable
and stable addresses for the data pointers; I don't know why...) the second
target board to run would find the old value of the seen array.  'array set'
doesn't do what the author of the testcase expected.

Is this OK?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

2002-01-09  Daniel Jacobowitz  <drow@mvista.com>

	* gdb.threads/linux-dp.exp: Use 'array unset', not 'array set'.
	(check_philosopher_stack): Check for manager thread before checking
	for a just-starting thread.

Index: linux-dp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/linux-dp.exp,v
retrieving revision 1.4
diff -u -p -r1.4 linux-dp.exp
--- linux-dp.exp	2001/05/25 01:29:01	1.4
+++ linux-dp.exp	2002/01/09 23:35:01
@@ -172,6 +172,15 @@ proc check_philosopher_stack {thread see
 	    }
 	    set interesting 1
 	}
+	-re ".* in __pthread_manager \\(.*$gdb_prompt $" {
+	    if {$manager_seen == 1} {
+		fail "manager thread is distinct: $thread"
+	    } else {
+		set manager_seen 1
+		pass "manager thread is distinct: $thread"
+	    }
+	    set interesting 1
+	}
 	-re "pthread_start_thread.*\r\n$gdb_prompt $" {
 	    ## Maybe the thread hasn't started yet.
 	    pass $name
@@ -185,15 +194,6 @@ proc check_philosopher_stack {thread see
 	    }
 	    set interesting 1
 	}
-	-re ".* in __pthread_manager \\(.*$gdb_prompt $" {
-	    if {$manager_seen == 1} {
-		fail "manager thread is distinct: $thread"
-	    } else {
-		set manager_seen 1
-		pass "manager thread is distinct: $thread"
-	    }
-	    set interesting 1
-	}
 	-re " in \\?\\?.*\r\n$gdb_prompt $" {
 	    ## Sometimes we can't get a backtrace.  I'm going to call
 	    ## this a pass, since we do verify that at least one
@@ -214,7 +214,7 @@ proc check_philosopher_stack {thread see
 }
 
 set any_interesting 0
-array set seen {}
+array unset seen
 for {set i 1} {$i <= 7} {incr i} {
     if [check_philosopher_stack $i seen] {
 	set any_interesting 1


             reply	other threads:[~2002-01-09 23:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-09 15:38 Daniel Jacobowitz [this message]
2002-01-29 21:57 ` Daniel Jacobowitz
2002-01-30  7:04   ` Fernando Nasser
2002-01-30 11:07     ` Michael Snyder
2002-01-30 14:19       ` Jim Blandy
2002-01-30 21:06         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020109183926.A17757@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox