Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: jhb@FreeBSD.org
Cc: Jim Wilson <jimw@sifive.com>,
	andrew.burgess@embecosm.com, schwab@suse.de,
	 gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] RISC-V: Add native linux support.
Date: Sat, 27 Oct 2018 06:07:00 -0000	[thread overview]
Message-ID: <mhng-b6af04ba-d225-4b44-a6e6-08200dc8910f@palmer-mbp2014> (raw)
In-Reply-To: <0cc883c4-e304-c3a9-adba-55ea434ec238@FreeBSD.org>

On Thu, 25 Oct 2018 12:19:29 PDT (-0700), jhb@FreeBSD.org wrote:
> On 10/25/18 11:17 AM, Jim Wilson wrote:
>> On Thu, Oct 25, 2018 at 10:55 AM John Baldwin <jhb@freebsd.org> wrote:
>>> Now that the MISA defaults to 0 if not present, would it better to just remove
>>> this and not set it to 0 explicitly?  The FreeBSD native target for RISC-V
>>> doesn't set MISA to anything at all.
>>
>> There is still the issue of FP register size, which comes from MISA,
>> unless perhaps we can get it from auxvec/hw-cap info.  I was going to
>> look into that latter, and if the auxvec/hw-cap stuff works, then
>> remove the remaining MISA support in the riscv-linux-nat.c file.
>
> Ok.  I do agree that auxvec is probably the right way to handle this, as what
> really matters is what format the kernel exports.  You can find existing uses
> of auxvec for this on 32-bit arm support where AT_HWCAP flags are tested for
> both Linux and FreeBSD in the respective tdep.c files to determine which
> floating point registers are available.  You are free to use the same code
> in a nat.c file as well of course.

We have a very simple scheme here: there's a bit for every ISA extension that 
is set in HWCAP by the kernel when that extension is present as far as 
userspace is concerned.  The code is probably easier to understand

    https://git.kernel.org/pub/scm/linux/kernel/git/palmer/riscv-linux.git/tree/arch/riscv/kernel/cpufeature.c#n33

We should probably but this in an ABI document somewhere... :)


  reply	other threads:[~2018-10-27  6:07 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  2:12 [PATCH 0/5] RISC-V Linux native port Jim Wilson
2018-08-08  2:15 ` [PATCH 1/5] RISC-V: Make riscv_isa_xlen a global function Jim Wilson
2018-08-08 12:42   ` Andrew Burgess
2018-08-08 17:55     ` Jim Wilson
2018-08-08 19:18   ` Simon Marchi
2018-08-08  2:16 ` [PATCH 2/5] RISC-V: Add software single step support Jim Wilson
2018-08-08 12:50   ` Andrew Burgess
2018-08-08 17:55     ` Jim Wilson
2018-08-08  2:16 ` [PATCH 3/5] RISC-V: Add linux target support Jim Wilson
2018-08-08 14:41   ` Andrew Burgess
2018-08-08 18:19     ` Jim Wilson
2018-08-08 18:35       ` Jim Wilson
2018-08-09 20:40         ` Jim Wilson
2018-08-08  2:17 ` [PATCH 4/5] RISC-V: Add native linux support Jim Wilson
2018-08-08 15:58   ` Andrew Burgess
2018-08-08 23:36     ` Jim Wilson
2018-08-08 23:39       ` Jim Wilson
2018-08-09  8:42         ` Andrew Burgess
2018-08-09 20:41           ` Jim Wilson
2018-10-25 10:49         ` Andreas Schwab
2018-10-25 11:09           ` Andrew Burgess
2018-10-25 12:06             ` Pedro Alves
2018-10-28 11:23               ` Andrew Burgess
2018-10-25 17:55             ` John Baldwin
2018-10-25 18:17               ` Jim Wilson
2018-10-25 19:19                 ` John Baldwin
2018-10-27  6:07                   ` Palmer Dabbelt [this message]
2018-10-29  8:50                 ` Andreas Schwab
2018-10-25 16:40           ` Jim Wilson
2018-08-08  2:17 ` [PATCH 5/5] RISC-V: Add configure support riscv*-linux* Jim Wilson
2018-08-08 16:00   ` Andrew Burgess
2018-08-08 17:30   ` Tom Tromey
2018-08-08 18:22     ` Eli Zaretskii
2018-08-08 20:49     ` Palmer Dabbelt
2018-08-08 23:26       ` Tom Tromey
2018-08-08 23:29         ` Tom Tromey
2018-08-09  2:36         ` Eli Zaretskii
2018-08-09  3:43           ` Jim Wilson
2018-08-09  4:55             ` Tom Tromey
2018-08-09  7:05             ` Andreas Schwab
2018-08-09 12:55             ` Eli Zaretskii
2018-08-09 17:25               ` Jim Wilson
2018-08-09  0:25     ` Jim Wilson
2018-08-09  0:29       ` [PATCH 5/5] RISC-V: Add configure support for riscv*-linux* Jim Wilson
2018-08-09  2:39         ` Eli Zaretskii
2018-08-09 15:57         ` Tom Tromey
2018-08-09 20:42           ` Jim Wilson
2018-08-08 12:41 ` [PATCH 0/5] RISC-V Linux native port Andrew Burgess
2018-08-08 17:41   ` Jim Wilson
2018-08-08 18:16     ` Andrew Burgess
2018-08-08 18:42       ` Jim Wilson
2018-08-09  3:18         ` Palmer Dabbelt
2018-08-10 18:04 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-b6af04ba-d225-4b44-a6e6-08200dc8910f@palmer-mbp2014 \
    --to=palmer@sifive.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    --cc=jimw@sifive.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox