From: Palmer Dabbelt <palmer@dabbelt.com>
To: Jim Wilson <jimw@sifive.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/riscv: add support for vector registers in target descriptions
Date: Thu, 06 May 2021 00:26:34 -0700 (PDT) [thread overview]
Message-ID: <mhng-3148d998-dacb-4431-af63-d7d3019ff35f@palmerdabbelt-glaptop> (raw)
In-Reply-To: <CAFyWVab8aJggRk7UX63s-9BMD19F==LMRQJtQMoA5knY49B-fg@mail.gmail.com>
On Wed, 05 May 2021 14:05:52 PDT (-0700), Jim Wilson wrote:
> On Wed, May 5, 2021 at 2:46 AM Andrew Burgess <andrew.burgess@embecosm.com>
> wrote:
>
>> This commit adds support to RISC-V GDB for vector registers in the
>> incoming target description.
>>
>
> It looks reasonable to me. Though I did notice that you have two comments
> which mention f-register instead of v-register.
>
> The vector spec isn't official yet, and hasn't been frozen yet, so there is
> a chance that some things will still change, but very unlikely that this
> patch would be affected. I can't imagine them changing the number of user
> registers at this point.
IMO that's fine: we can maintain a stable ABI for this, even in the
unlikely event that the number of vector registers changes we'll just
end up with some unused register indices. We're already relying on an
external mechanism to determine the semantics of the CSRs, as we've
allocated register numbers for all of those despite most not being in
any spec.
next prev parent reply other threads:[~2021-05-06 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 9:46 Andrew Burgess
2021-05-05 21:05 ` Jim Wilson
2021-05-06 7:26 ` Palmer Dabbelt [this message]
2021-06-21 11:04 ` [PATCHv2] " Andrew Burgess
2021-06-21 11:41 ` Eli Zaretskii via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-3148d998-dacb-4431-af63-d7d3019ff35f@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=gdb-patches@sourceware.org \
--cc=jimw@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox