Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Wilson <jimw@sifive.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/riscv: add support for vector registers in target descriptions
Date: Wed, 5 May 2021 14:05:52 -0700	[thread overview]
Message-ID: <CAFyWVab8aJggRk7UX63s-9BMD19F==LMRQJtQMoA5knY49B-fg@mail.gmail.com> (raw)
In-Reply-To: <20210505094639.1551740-1-andrew.burgess@embecosm.com>

On Wed, May 5, 2021 at 2:46 AM Andrew Burgess <andrew.burgess@embecosm.com>
wrote:

> This commit adds support to RISC-V GDB for vector registers in the
> incoming target description.
>

It looks reasonable to me.  Though I did notice that you have two comments
which mention f-register instead of v-register.

The vector spec isn't official yet, and hasn't been frozen yet, so there is
a chance that some things will still change, but very unlikely that this
patch would be affected.  I can't imagine them changing the number of user
registers at this point.

Jim

  reply	other threads:[~2021-05-05 21:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05  9:46 Andrew Burgess
2021-05-05 21:05 ` Jim Wilson [this message]
2021-05-06  7:26   ` Palmer Dabbelt
2021-06-21 11:04 ` [PATCHv2] " Andrew Burgess
2021-06-21 11:41   ` Eli Zaretskii via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyWVab8aJggRk7UX63s-9BMD19F==LMRQJtQMoA5knY49B-fg@mail.gmail.com' \
    --to=jimw@sifive.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox