Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: dje@google.com (Doug Evans)
Cc: gcc-patches@gcc.gnu.org,  binutils@sourceware.org,
	 gdb-patches@sourceware.org
Subject: Re: [RFA] leb128.h: New file.
Date: Mon, 21 May 2012 17:09:00 -0000	[thread overview]
Message-ID: <mcraa115ums.fsf@dhcp-172-18-216-180.mtv.corp.google.com> (raw)
In-Reply-To: <20120517182920.64FAE2461B2@ruffy.mtv.corp.google.com> (Doug	Evans's message of "Thu, 17 May 2012 11:29:20 -0700 (PDT)")

dje@google.com (Doug Evans) writes:

> 2012-05-17  Doug Evans  <dje@google.com>
>
> 	* leb128.h: New file.

I'm not entirely sure about the use of int64_t to hold the result.  Do
we want to let this interface support larger types some day?  E.g.,
should the result be long long?

I'll approve this patch, but think about it.

The patch is not as portable as possible, but it will probably be OK in
practice.  You should deal with any issues that arise.

Thanks.

Ian


  parent reply	other threads:[~2012-05-21 17:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 18:29 Doug Evans
2012-05-21  0:31 ` Doug Evans
2012-05-21 14:21   ` Jan Kratochvil
2012-05-21 17:09 ` Ian Lance Taylor [this message]
2012-05-21 17:36   ` Doug Evans
2012-05-21 18:22     ` Ian Lance Taylor
  -- strict thread matches above, loose matches on Subject: below --
2012-05-15  5:02 Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcraa115ums.fsf@dhcp-172-18-216-180.mtv.corp.google.com \
    --to=iant@google.com \
    --cc=binutils@sourceware.org \
    --cc=dje@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox