From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25326 invoked by alias); 21 May 2012 17:09:18 -0000 Received: (qmail 25308 invoked by uid 22791); 21 May 2012 17:09:15 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 May 2012 17:09:01 +0000 Received: by pbbrp2 with SMTP id rp2so7651219pbb.0 for ; Mon, 21 May 2012 10:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:x-gm-message-state; bh=bKHNZX4MAS3VWyYIsJ9eXlpNpk0QXEUQlgYJAnwx3QM=; b=hDKKZlze1P2z6VRB7r/5jsSrR2eXGW19+HXbtsCe8CJSIN2y+KTHg+pURFHQvQL5NF RZU5mnFFfb/kXM5OapkPuhDicgnOXI6GcQLv1rg4dfoVgfqC0G++s9I/bgBW5axJLSbf V/bnqNvapnNWETnaIZ2m4MuVxXvFW/0PEOG01TFwOD28pWHUCqe84WmTQqGw0abd+mXP VsVfj24WunrEZm07zQ64a1FIiMHfF//ErUQvIv8nA7EF7QNtTiGDNUgZoaTXz2OC/KzF 7vfJMekWTuAyc2hERwd7CmChvhQ5f+ujWeShxSxT650G5WRoDTmAw9UlVtwBj4y2J1j1 4q8Q== Received: by 10.68.238.228 with SMTP id vn4mr5820453pbc.132.1337620141351; Mon, 21 May 2012 10:09:01 -0700 (PDT) Received: by 10.68.238.228 with SMTP id vn4mr5820424pbc.132.1337620141148; Mon, 21 May 2012 10:09:01 -0700 (PDT) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id pw10sm23656814pbb.61.2012.05.21.10.09.00 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 May 2012 10:09:00 -0700 (PDT) From: Ian Lance Taylor To: dje@google.com (Doug Evans) Cc: gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [RFA] leb128.h: New file. References: <20120517182920.64FAE2461B2@ruffy.mtv.corp.google.com> Date: Mon, 21 May 2012 17:09:00 -0000 In-Reply-To: <20120517182920.64FAE2461B2@ruffy.mtv.corp.google.com> (Doug Evans's message of "Thu, 17 May 2012 11:29:20 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Gm-Message-State: ALoCoQmZw16qGLd7c0HmagL335QCWIW9EQ5VZqxWA1HXWgyjJocYCv/2kdO99zQFZdXJpt8UO9FUHSbc66DZ4BtHAMrCanfi4QCk0bD2p3P0JJevlV1XR8u48ppzdaxvLn7ItYPcgsKpdk1LuhKaf0rJwzJlTs9cl8DgSOenIgIV9+cAwQ5DCKY= Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00776.txt.bz2 dje@google.com (Doug Evans) writes: > 2012-05-17 Doug Evans > > * leb128.h: New file. I'm not entirely sure about the use of int64_t to hold the result. Do we want to let this interface support larger types some day? E.g., should the result be long long? I'll approve this patch, but think about it. The patch is not as portable as possible, but it will probably be OK in practice. You should deal with any issues that arise. Thanks. Ian