From: Doug Evans <dje@google.com>
To: Ian Lance Taylor <iant@google.com>
Cc: gcc-patches@gcc.gnu.org, binutils@sourceware.org,
gdb-patches@sourceware.org,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [RFA] leb128.h: New file.
Date: Mon, 21 May 2012 17:36:00 -0000 [thread overview]
Message-ID: <CADPb22T-CP4bhAy20Mw0QZ6F6iPdYDdicOx6VrLtRPtMC0X+UQ@mail.gmail.com> (raw)
In-Reply-To: <mcraa115ums.fsf@dhcp-172-18-216-180.mtv.corp.google.com>
On Mon, May 21, 2012 at 10:08 AM, Ian Lance Taylor <iant@google.com> wrote:
> dje@google.com (Doug Evans) writes:
>
>> 2012-05-17 Doug Evans <dje@google.com>
>>
>> * leb128.h: New file.
>
> I'm not entirely sure about the use of int64_t to hold the result. Do
> we want to let this interface support larger types some day? E.g.,
> should the result be long long?
>
> I'll approve this patch, but think about it.
>
> The patch is not as portable as possible, but it will probably be OK in
> practice. You should deal with any issues that arise.
I'll change the result to size_t per Jan's request.
I'm kinda worried about putting people to extra effort when they
compile with -Wconversion which is why I went with int (thinking
people would rather just use an int). But ok.
long long (+ unsigned long long) is ok by me.
I could also rename the functions to read_uleb128_to_ull (unsigned
long long) to allow for a day if/when someone wants
read_uleb128_to_uint64. Ok?
next prev parent reply other threads:[~2012-05-21 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 18:29 Doug Evans
2012-05-21 0:31 ` Doug Evans
2012-05-21 14:21 ` Jan Kratochvil
2012-05-21 17:09 ` Ian Lance Taylor
2012-05-21 17:36 ` Doug Evans [this message]
2012-05-21 18:22 ` Ian Lance Taylor
-- strict thread matches above, loose matches on Subject: below --
2012-05-15 5:02 Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22T-CP4bhAy20Mw0QZ6F6iPdYDdicOx6VrLtRPtMC0X+UQ@mail.gmail.com \
--to=dje@google.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=iant@google.com \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox