From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Add task-specific breakpoint capability...
Date: Wed, 25 Mar 2009 16:39:00 -0000 [thread overview]
Message-ID: <m3zlf9zhnh.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090325162711.GX9472@adacore.com> (Joel Brobecker's message of "Wed\, 25 Mar 2009 09\:27\:11 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> Humpf. Forgot the new patch.
I blame your MUA :)
Joel> +int
Joel> +breakpoint_ada_task_match (CORE_ADDR pc, ptid_t ptid)
Joel> +{
Joel> + struct bp_location *bpt;
Joel> + int taskid = ada_get_task_number (ptid);
Joel> +
Joel> + ALL_BP_LOCATIONS (bpt)
[...]
Joel> - if (!breakpoint_thread_match (stop_pc, ecs->ptid))
Joel> + if (!breakpoint_thread_match (stop_pc, ecs->ptid)
Joel> + || !breakpoint_ada_task_match (stop_pc, ecs->ptid))
Joel> thread_hop_needed = 1;
It seems like it would be more efficient to combine
breakpoint_thread_match and breakpoint_ada_task_match, so we only
have a single loop over all breakpoint locations.
This is probably not very important.
Tom
next prev parent reply other threads:[~2009-03-25 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 21:27 Joel Brobecker
2009-03-24 23:55 ` Tom Tromey
2009-03-25 16:27 ` Joel Brobecker
2009-03-25 16:34 ` Joel Brobecker
2009-03-25 16:39 ` Tom Tromey [this message]
2009-03-25 17:49 ` Joel Brobecker
2009-03-25 19:58 ` Joel Brobecker
2009-03-25 21:22 ` Eli Zaretskii
2009-03-31 16:55 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zlf9zhnh.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox