From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-62442-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 464 invoked by alias); 25 Mar 2009 16:34:31 -0000
Received: (qmail 450 invoked by uid 22791); 25 Mar 2009 16:34:30 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Mar 2009 16:34:24 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2PGXfi6000425; 	Wed, 25 Mar 2009 12:33:41 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2PGXYoJ022485; 	Wed, 25 Mar 2009 12:33:35 -0400
Received: from opsy.redhat.com (vpn-13-99.rdu.redhat.com [10.11.13.99]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2PGXeSj013574; 	Wed, 25 Mar 2009 12:33:40 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id B296B3785DA; Wed, 25 Mar 2009 10:33:38 -0600 (MDT)
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Add task-specific breakpoint capability...
References: <20090324203319.GB24100@adacore.com> 	<m3fxh232i5.fsf@fleche.redhat.com> <20090325162141.GW9472@adacore.com> 	<20090325162711.GX9472@adacore.com>
From: Tom Tromey <tromey@redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Wed, 25 Mar 2009 16:39:00 -0000
In-Reply-To: <20090325162711.GX9472@adacore.com> (Joel Brobecker's message of "Wed\, 25 Mar 2009 09\:27\:11 -0700")
Message-ID: <m3zlf9zhnh.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-03/txt/msg00552.txt.bz2

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Humpf. Forgot the new patch.

I blame your MUA :)

Joel> +int
Joel> +breakpoint_ada_task_match (CORE_ADDR pc, ptid_t ptid)
Joel> +{
Joel> +  struct bp_location *bpt;
Joel> +  int taskid = ada_get_task_number (ptid);
Joel> +
Joel> +  ALL_BP_LOCATIONS (bpt)
[...]

Joel> -	  if (!breakpoint_thread_match (stop_pc, ecs->ptid))
Joel> +	  if (!breakpoint_thread_match (stop_pc, ecs->ptid)
Joel> +	      || !breakpoint_ada_task_match (stop_pc, ecs->ptid))
Joel>  	    thread_hop_needed = 1;

It seems like it would be more efficient to combine
breakpoint_thread_match and breakpoint_ada_task_match, so we only
have a single loop over all breakpoint locations.
This is probably not very important.

Tom