Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Add task-specific breakpoint capability...
Date: Wed, 25 Mar 2009 16:27:00 -0000	[thread overview]
Message-ID: <20090325162141.GW9472@adacore.com> (raw)
In-Reply-To: <m3fxh232i5.fsf@fleche.redhat.com>

> FWIW this approach seems reasonable enough to me.

Cool :)

> Joel> +int
> Joel> +breakpoint_ada_task_match (CORE_ADDR pc, ptid_t ptid)
> 
> Nothing calls this.  Maybe the patch is missing changes from
> infrun.c, and a declaration in breakpoint.h?

That's a really good catch - Indeed, I forgot the change in infrun.c.
And I moved the function declaration from ada-lang.h to breakpoint.h,
as suggested. Not sure why we put that declaration in ada-lang.h in
the first place - probably force of habits...

-- 
Joel


  reply	other threads:[~2009-03-25 16:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 21:27 Joel Brobecker
2009-03-24 23:55 ` Tom Tromey
2009-03-25 16:27   ` Joel Brobecker [this message]
2009-03-25 16:34     ` Joel Brobecker
2009-03-25 16:39       ` Tom Tromey
2009-03-25 17:49         ` Joel Brobecker
2009-03-25 19:58           ` Joel Brobecker
2009-03-25 21:22             ` Eli Zaretskii
2009-03-31 16:55             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090325162141.GW9472@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox