From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10751 invoked by alias); 25 Mar 2009 16:21:56 -0000 Received: (qmail 10740 invoked by uid 22791); 25 Mar 2009 16:21:55 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Mar 2009 16:21:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CC9F72BAC1B; Wed, 25 Mar 2009 12:21:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lvPoFUV3cFsy; Wed, 25 Mar 2009 12:21:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 978D12BAC26; Wed, 25 Mar 2009 12:21:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6ED205BD21; Wed, 25 Mar 2009 09:21:41 -0700 (PDT) Date: Wed, 25 Mar 2009 16:27:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Add task-specific breakpoint capability... Message-ID: <20090325162141.GW9472@adacore.com> References: <20090324203319.GB24100@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00550.txt.bz2 > FWIW this approach seems reasonable enough to me. Cool :) > Joel> +int > Joel> +breakpoint_ada_task_match (CORE_ADDR pc, ptid_t ptid) > > Nothing calls this. Maybe the patch is missing changes from > infrun.c, and a declaration in breakpoint.h? That's a really good catch - Indeed, I forgot the change in infrun.c. And I moved the function declaration from ada-lang.h to breakpoint.h, as suggested. Not sure why we put that declaration in ada-lang.h in the first place - probably force of habits... -- Joel