From: Tom Tromey <tromey@redhat.com>
To: Ozkan Sezer <sezeroz@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix build failure for win64, revise some format strings
Date: Fri, 16 Jul 2010 18:47:00 -0000 [thread overview]
Message-ID: <m3zkxri7rn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <AANLkTilXvUJo6hqsP7jfMhSVA6Pdv8pv1cZnheoHSDj8@mail.gmail.com> (Ozkan Sezer's message of "Fri, 16 Jul 2010 20:18:19 +0300")
>>>>> "Ozkan" == Ozkan Sezer <sezeroz@gmail.com> writes:
Ozkan> gdb/gdbserver/
Ozkan> * server.c (handle_query): For windows, Use %I64d instead of
Ozkan> %lld in the sprintf format string.
I don't know much about gdbserver. So I am going to ask that someone
else look at this part.
Ozkan> (Note: debug_to_region_ok_for_hw_watchpoint() specifically
Ozkan> did not use 0x%lx but only %ld for the addr value. Should I
Ozkan> not care, or should I change my patch to use
Ozkan> host_address_to_string ((void *) addr) + 2
Ozkan> ... to skip the "0x" instead?
Don't worry about it, using host_address_to_string is fine.
Ozkan> + host_address_to_string ((void *) bp_tgt->placed_address),
I think you should not need these casts to void*.
The gdb parts of this patch are ok with that change. Thanks.
Tom
next prev parent reply other threads:[~2010-07-16 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 10:14 Ozkan Sezer
2010-07-12 11:51 ` Ozkan Sezer
2010-07-15 18:55 ` Ozkan Sezer
2010-07-16 15:36 ` Tom Tromey
2010-07-16 17:18 ` Ozkan Sezer
2010-07-16 18:47 ` Tom Tromey [this message]
2010-07-16 18:50 ` Ozkan Sezer
2010-07-16 19:07 ` Tom Tromey
2010-07-16 19:30 ` Ozkan Sezer
2010-07-16 19:53 ` Tom Tromey
2010-07-16 20:10 ` Ozkan Sezer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zkxri7rn.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sezeroz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox