From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74355-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26488 invoked by alias); 16 Jul 2010 18:47:19 -0000
Received: (qmail 26477 invoked by uid 22791); 16 Jul 2010 18:47:18 -0000
X-SWARE-Spam-Status: No, hits=-6.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Jul 2010 18:47:13 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6GIlAxg032066	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 16 Jul 2010 14:47:10 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6GIlAr9029634;	Fri, 16 Jul 2010 14:47:10 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6GIl9Cr024087;	Fri, 16 Jul 2010 14:47:09 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 0EC0A378B97; Fri, 16 Jul 2010 12:47:09 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Ozkan Sezer <sezeroz@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix build failure for win64, revise some format strings
References: <AANLkTikmIiWftrZjNCeAzF2h9s22-puuc9mzoYg1rHGV@mail.gmail.com>	<AANLkTimHpuOLt9hrqVKk3b0Geh1ekt_am_SQuwR9dPk3@mail.gmail.com>	<AANLkTinH2cGhzqV-9br3fJIZmd2T92KNHlMDCZ8Tq4Yy@mail.gmail.com>	<m3d3unjv6t.fsf@fleche.redhat.com>	<AANLkTilXvUJo6hqsP7jfMhSVA6Pdv8pv1cZnheoHSDj8@mail.gmail.com>
Date: Fri, 16 Jul 2010 18:47:00 -0000
In-Reply-To: <AANLkTilXvUJo6hqsP7jfMhSVA6Pdv8pv1cZnheoHSDj8@mail.gmail.com>	(Ozkan Sezer's message of "Fri, 16 Jul 2010 20:18:19 +0300")
Message-ID: <m3zkxri7rn.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00246.txt.bz2

>>>>> "Ozkan" == Ozkan Sezer <sezeroz@gmail.com> writes:

Ozkan> gdb/gdbserver/
Ozkan> 	* server.c (handle_query): For windows, Use %I64d instead of
Ozkan> 	%lld in the sprintf format string.

I don't know much about gdbserver.  So I am going to ask that someone
else look at this part.

Ozkan> (Note: debug_to_region_ok_for_hw_watchpoint() specifically
Ozkan> did not use 0x%lx but only %ld for the addr value.  Should I
Ozkan> not care, or should I change my patch to use
Ozkan> host_address_to_string ((void *) addr) + 2
Ozkan> ... to skip the "0x" instead?

Don't worry about it, using host_address_to_string is fine.

Ozkan> +		      host_address_to_string ((void *) bp_tgt->placed_address),

I think you should not need these casts to void*.

The gdb parts of this patch are ok with that change.  Thanks.

Tom