Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Ozkan Sezer <sezeroz@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix build failure for win64, revise some format strings
Date: Fri, 16 Jul 2010 15:36:00 -0000	[thread overview]
Message-ID: <m3d3unjv6t.fsf@fleche.redhat.com> (raw)
In-Reply-To: <AANLkTinH2cGhzqV-9br3fJIZmd2T92KNHlMDCZ8Tq4Yy@mail.gmail.com>	(Ozkan Sezer's message of "Thu, 15 Jul 2010 21:55:05 +0300")

>>>>> "Ozkan" == Ozkan Sezer <sezeroz@gmail.com> writes:

Ozkan> PING
Ozkan> Can someone please review this patch? (Win64 fails to build for a week.)

Sorry about that.  I was hoping someone else would do this ;-)

Thanks for pinging.

I think it would be better to change those places to use
host_address_to_string.  E.g., change from:

  fprintf_unfiltered (gdb_stdlog,
		      "target_insert_breakpoint (0x%lx, xxx) = %ld\n",
		      (unsigned long) bp_tgt->placed_address,
		      (unsigned long) retval);

to

  fprintf_unfiltered (gdb_stdlog,
		      "target_insert_breakpoint (%s, xxx) = %ld\n",
		      host_address_to_string (bp_tgt->placed_address),
		      (unsigned long) retval);


This lets us avoid dealing with the gnulib changes, etc.

Tom


  reply	other threads:[~2010-07-16 15:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 10:14 Ozkan Sezer
2010-07-12 11:51 ` Ozkan Sezer
2010-07-15 18:55   ` Ozkan Sezer
2010-07-16 15:36     ` Tom Tromey [this message]
2010-07-16 17:18       ` Ozkan Sezer
2010-07-16 18:47         ` Tom Tromey
2010-07-16 18:50           ` Ozkan Sezer
2010-07-16 19:07             ` Tom Tromey
2010-07-16 19:30               ` Ozkan Sezer
2010-07-16 19:53                 ` Tom Tromey
2010-07-16 20:10                   ` Ozkan Sezer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d3unjv6t.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sezeroz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox