Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Saturday, December 28 2013, Joel Brobecker wrote:

>> 2013-12-23  Sergio Durigan Junior  <sergiodj@redhat.com>
>> 
>> 	* NEWS: Mention SystemTap SDT probe support for AArch64 GNU/Linux.
>> 	* aarch64-linux-tdep.c: Include necessary headers for parsing of
>> 	SystemTap SDT probes.
>> 	(aarch64_stap_is_single_operand): New function.
>> 	(aarch64_stap_parse_special_token): Likewise.
>> 	(aarch64_linux_init_abi): Declare SystemTap SDT probe argument
>> 	prefixes and suffixes.  Initialize gdbarch with them.
>
> First of all, thanks to Yufeng and Marcus for reviewing the patch.
> That was very useful.
>
> The patch is therefore approved, with one small request:

Thanks a lot, Joel.

>>  }
>>  
>> +static int
>> +aarch64_stap_is_single_operand (struct gdbarch *gdbarch, const char *s)
>> +{
>> +  return (*s == '#' || isdigit (*s) /* Literal number.  */
>> +	  || *s == '[' /* Register indirection.  */
>> +	  || isalpha (*s)); /* Register value.  */
>> +}
>
> Can you document this function?

Yes, fixed.

Checked in:

        <https://sourceware.org/ml/gdb-cvs/2013-12/msg00123.html>

Thanks,

-- 
Sergio