From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12172 invoked by alias); 28 Dec 2013 16:22:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12157 invoked by uid 89); 28 Dec 2013 16:22:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 28 Dec 2013 16:22:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBSGM21I010421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Dec 2013 11:22:02 -0500 Received: from psique ([10.3.113.9]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBSGLwoU014506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 28 Dec 2013 11:22:00 -0500 From: Sergio Durigan Junior To: Joel Brobecker Cc: Yufeng Zhang , GDB Patches , Marcus Shawcroft , Tom Tromey Subject: Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64 References: <52B86A61.1010004@arm.com> <20131228033514.GE4532@adacore.com> X-URL: http://www.redhat.com Date: Sat, 28 Dec 2013 16:22:00 -0000 In-Reply-To: <20131228033514.GE4532@adacore.com> (Joel Brobecker's message of "Sat, 28 Dec 2013 07:35:14 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00980.txt.bz2 On Saturday, December 28 2013, Joel Brobecker wrote: >> 2013-12-23 Sergio Durigan Junior >> >> * NEWS: Mention SystemTap SDT probe support for AArch64 GNU/Linux. >> * aarch64-linux-tdep.c: Include necessary headers for parsing of >> SystemTap SDT probes. >> (aarch64_stap_is_single_operand): New function. >> (aarch64_stap_parse_special_token): Likewise. >> (aarch64_linux_init_abi): Declare SystemTap SDT probe argument >> prefixes and suffixes. Initialize gdbarch with them. > > First of all, thanks to Yufeng and Marcus for reviewing the patch. > That was very useful. > > The patch is therefore approved, with one small request: Thanks a lot, Joel. >> } >> >> +static int >> +aarch64_stap_is_single_operand (struct gdbarch *gdbarch, const char *s) >> +{ >> + return (*s == '#' || isdigit (*s) /* Literal number. */ >> + || *s == '[' /* Register indirection. */ >> + || isalpha (*s)); /* Register value. */ >> +} > > Can you document this function? Yes, fixed. Checked in: Thanks, -- Sergio