Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64

[Yufeng Zhang <Yufeng.Zhang@arm.com>]

Hi Sergio,

Thanks for the updated patch.  It looks OK to me and the only comment I 
have is about the '$' character.  In A64, only '#' can be the optional 
prefix for immediate.  I didn't see '$' checked in your original patch; 
is there a particular reason that you added support for '$' in this patch?

Thanks,
Yufeng

p.s. I cannot approve patch and Marcus is on holiday, so you may need to 
seek an approval from a global maintainer if you need to get the patch 
in before 7.7 is branched.

On 12/19/13 22:20, Sergio Durigan Junior wrote:
> Hi,
>
> This is the second attempt to implement SystemTap SDT probe support for
> AArch64 GNU/Linux targets.  You can see the first attempt here:
>
> <https://sourceware.org/ml/gdb-patches/2013-11/msg00745.html>
>
> After my last patch for the SystemTap SDT API, which extends it in order
> to accept multiple prefixes and suffixes, this patch became simpler.  I
> also followed Marcus suggestion and did not shared code between 32- and
> 64-bit ARM.
>
> Tom asked me in a previous message how I did my tests.  I believe I
> replied that, but just in case: I ran the tests on
> gdb.base/stap-probe.exp by hand.  As I write this message, I'm working
> on getting a way to run the full testsuite.  Will update this thread
> if/when I succeed.
>
> I'd like to apply this before Joel creates the 7.7 branch.  Let's see
> :-).
>
> OK to apply?
>
> Thanks,
>