From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6087 invoked by alias); 23 Dec 2013 16:52:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5993 invoked by uid 89); 23 Dec 2013 16:52:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Dec 2013 16:52:53 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 23 Dec 2013 16:52:50 +0000 Received: from [10.1.201.52] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 23 Dec 2013 16:52:49 +0000 Message-ID: <52B86A61.1010004@arm.com> Date: Mon, 23 Dec 2013 16:52:00 -0000 From: Yufeng Zhang User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches , Marcus Shawcroft , Tom Tromey Subject: Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64 References: In-Reply-To: X-MC-Unique: 113122316525001601 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00884.txt.bz2 Hi Sergio, Thanks for the updated patch. It looks OK to me and the only comment I=20 have is about the '$' character. In A64, only '#' can be the optional=20 prefix for immediate. I didn't see '$' checked in your original patch;=20 is there a particular reason that you added support for '$' in this patch? Thanks, Yufeng p.s. I cannot approve patch and Marcus is on holiday, so you may need to=20 seek an approval from a global maintainer if you need to get the patch=20 in before 7.7 is branched. On 12/19/13 22:20, Sergio Durigan Junior wrote: > Hi, > > This is the second attempt to implement SystemTap SDT probe support for > AArch64 GNU/Linux targets. You can see the first attempt here: > > > > After my last patch for the SystemTap SDT API, which extends it in order > to accept multiple prefixes and suffixes, this patch became simpler. I > also followed Marcus suggestion and did not shared code between 32- and > 64-bit ARM. > > Tom asked me in a previous message how I did my tests. I believe I > replied that, but just in case: I ran the tests on > gdb.base/stap-probe.exp by hand. As I write this message, I'm working > on getting a way to run the full testsuite. Will update this thread > if/when I succeed. > > I'd like to apply this before Joel creates the 7.7 branch. Let's see > :-). > > OK to apply? > > Thanks, >