Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ian Lance Taylor <ian@airs.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org,
	djgpp-workers@delorie.com
Subject: Re: RFA: fix libiberty/pex-djgpp.c
Date: Wed, 11 May 2005 23:13:00 -0000	[thread overview]
Message-ID: <m3y8alqzgx.fsf@gossamer.airs.com> (raw)
In-Reply-To: <01c5565c$Blat.v2.4$082130a0@zahav.net.il>

"Eli Zaretskii" <eliz@gnu.org> writes:

> The current CVS version of pex-djgpp.c didn't compile.  The patch
> below fixes the problems I spotted; please review it.

Thanks for doing this.  I did not have a DJGPP system to try this code
out on.  It was obviously in fairly bad shape.

You don't need pex_djgpp_fdopenr.  It will only be called if
pex_init_common is called with PEX_USE_PIPES, which should never
happen since pex_init in pex-djgpp.c clears PEX_USE_PIPES.

Otherwise, this patch is approved.  Please check it into the gcc
repository first, as usual with libiberty patches.

Thanks.

Ian


  reply	other threads:[~2005-05-11 20:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-11 19:15 Eli Zaretskii
2005-05-11 23:13 ` Ian Lance Taylor [this message]
2005-05-11 23:31   ` Eli Zaretskii
2005-05-12  3:46     ` Ian Lance Taylor
2005-05-12  6:56       ` Ian Lance Taylor
2005-05-12  7:06         ` Eli Zaretskii
2005-05-12  7:36       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y8alqzgx.fsf@gossamer.airs.com \
    --to=ian@airs.com \
    --cc=djgpp-workers@delorie.com \
    --cc=eliz@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox