From: "Eli Zaretskii" <eliz@gnu.org>
To: djgpp-workers@delorie.com
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: RFA: fix libiberty/pex-djgpp.c
Date: Wed, 11 May 2005 23:31:00 -0000 [thread overview]
Message-ID: <01c55680$Blat.v2.4$9ebe4740@zahav.net.il> (raw)
In-Reply-To: <m3y8alqzgx.fsf@gossamer.airs.com> (message from Ian Lance Taylor on 11 May 2005 16:28:30 -0400)
> Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org,
> djgpp-workers@delorie.com
> From: Ian Lance Taylor <ian@airs.com>
> Date: 11 May 2005 16:28:30 -0400
>
> You don't need pex_djgpp_fdopenr. It will only be called if
> pex_init_common is called with PEX_USE_PIPES
It's not easy to figure out what is needed and in what conditions. It
would be nice if this machinery were to be documented a bit more
methodically. Right now, the information is scattered between
pex-common.h, include/libiberty.h and a few comments in pex-*.c files.
> Otherwise, this patch is approved. Please check it into the gcc
> repository first, as usual with libiberty patches.
I don't think I have write access to the GCC repository, sorry.
Anyway, thanks for a timely review.
next prev parent reply other threads:[~2005-05-11 23:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 19:15 Eli Zaretskii
2005-05-11 23:13 ` Ian Lance Taylor
2005-05-11 23:31 ` Eli Zaretskii [this message]
2005-05-12 3:46 ` Ian Lance Taylor
2005-05-12 6:56 ` Ian Lance Taylor
2005-05-12 7:06 ` Eli Zaretskii
2005-05-12 7:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c55680$Blat.v2.4$9ebe4740@zahav.net.il' \
--to=eliz@gnu.org \
--cc=djgpp-workers@delorie.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox