From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30021 invoked by alias); 11 May 2005 23:27:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29820 invoked from network); 11 May 2005 23:27:01 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 11 May 2005 23:27:01 -0000 Received: from zaretski (IGLD-83-130-254-105.inter.net.il [83.130.254.105]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id BEV01042 (AUTH halo1); Thu, 12 May 2005 02:26:54 +0300 (IDT) Date: Wed, 11 May 2005 23:31:00 -0000 From: "Eli Zaretskii" To: djgpp-workers@delorie.com Message-ID: <01c55680$Blat.v2.4$9ebe4740@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org In-reply-to: (message from Ian Lance Taylor on 11 May 2005 16:28:30 -0400) Subject: Re: RFA: fix libiberty/pex-djgpp.c Reply-to: Eli Zaretskii References: <01c5565c$Blat.v2.4$082130a0@zahav.net.il> X-SW-Source: 2005-05/txt/msg00260.txt.bz2 > Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, > djgpp-workers@delorie.com > From: Ian Lance Taylor > Date: 11 May 2005 16:28:30 -0400 > > You don't need pex_djgpp_fdopenr. It will only be called if > pex_init_common is called with PEX_USE_PIPES It's not easy to figure out what is needed and in what conditions. It would be nice if this machinery were to be documented a bit more methodically. Right now, the information is scattered between pex-common.h, include/libiberty.h and a few comments in pex-*.c files. > Otherwise, this patch is approved. Please check it into the gcc > repository first, as usual with libiberty patches. I don't think I have write access to the GCC repository, sorry. Anyway, thanks for a timely review.