From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22215 invoked by alias); 11 May 2005 20:44:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22136 invoked from network); 11 May 2005 20:44:50 -0000 Received: from unknown (205.217.158.180) by sourceware.org with QMTP; 11 May 2005 20:44:50 -0000 Received: (qmail 30609 invoked by uid 10); 11 May 2005 20:44:49 -0000 Received: (qmail 7809 invoked by uid 500); 11 May 2005 20:28:30 -0000 To: Eli Zaretskii Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, djgpp-workers@delorie.com Subject: Re: RFA: fix libiberty/pex-djgpp.c References: <01c5565c$Blat.v2.4$082130a0@zahav.net.il> From: Ian Lance Taylor Date: Wed, 11 May 2005 23:13:00 -0000 In-Reply-To: <01c5565c$Blat.v2.4$082130a0@zahav.net.il> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-05/txt/msg00256.txt.bz2 "Eli Zaretskii" writes: > The current CVS version of pex-djgpp.c didn't compile. The patch > below fixes the problems I spotted; please review it. Thanks for doing this. I did not have a DJGPP system to try this code out on. It was obviously in fairly bad shape. You don't need pex_djgpp_fdopenr. It will only be called if pex_init_common is called with PEX_USE_PIPES, which should never happen since pex_init in pex-djgpp.c clears PEX_USE_PIPES. Otherwise, this patch is approved. Please check it into the gcc repository first, as usual with libiberty patches. Thanks. Ian