From: Jim Blandy <jimb@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: remove redundant code in ada-lang.c
Date: Fri, 01 Dec 2006 00:38:00 -0000 [thread overview]
Message-ID: <m3y7ps78n6.fsf@codesourcery.com> (raw)
In-Reply-To: <20061201000754.GE6637@adacore.com> (Joel Brobecker's message of "Thu, 30 Nov 2006 16:07:54 -0800")
Joel Brobecker <brobecker@adacore.com> writes:
>> I don't have an Ada compiler handy, so I can't test this, but does
>> this look right, Joel? It seems to me that since
>> ada_value_primitive_packed_val is passed arr as its 'obj' parameter,
>> v's lvalue type should already be set accordingly.
>>
>> 2006-11-22 Jim Blandy <jimb@codesourcery.com>
>>
>> * ada-lang.c (value_subscript_packed): Don't bother to set the
>> lvalue type of the returned value here;
>> ada_value_primitive_packed_val takes care of that.
>
> Paul Hilfinger reviewed the patch for us and said that it looked good.
> I tested it on my laptop and showed no regression.
Committed --- thanks!
prev parent reply other threads:[~2006-12-01 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 0:31 Jim Blandy
2006-12-01 0:07 ` Joel Brobecker
2006-12-01 0:38 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y7ps78n6.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox