Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: RFA: remove redundant code in ada-lang.c
Date: Thu, 30 Nov 2006 00:31:00 -0000	[thread overview]
Message-ID: <m3ejrlai5p.fsf@codesourcery.com> (raw)


I don't have an Ada compiler handy, so I can't test this, but does
this look right, Joel?  It seems to me that since
ada_value_primitive_packed_val is passed arr as its 'obj' parameter,
v's lvalue type should already be set accordingly.

2006-11-22  Jim Blandy  <jimb@codesourcery.com>

	* ada-lang.c (value_subscript_packed): Don't bother to set the
	lvalue type of the returned value here;
	ada_value_primitive_packed_val takes care of that.

Index: gdb-jimb-browse/gdb/ada-lang.c
===================================================================
--- gdb-jimb-browse.orig/gdb/ada-lang.c	2006-11-29 14:59:32.000000000 -0800
+++ gdb-jimb-browse/gdb/ada-lang.c	2006-11-29 15:06:43.393216000 -0800
@@ -1887,10 +1887,6 @@
 
   v = ada_value_primitive_packed_val (arr, NULL, elt_off, bit_off,
                                       bits, elt_type);
-  if (VALUE_LVAL (arr) == lval_internalvar)
-    VALUE_LVAL (v) = lval_internalvar_component;
-  else
-    VALUE_LVAL (v) = VALUE_LVAL (arr);
   return v;
 }
 


             reply	other threads:[~2006-11-30  0:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30  0:31 Jim Blandy [this message]
2006-12-01  0:07 ` Joel Brobecker
2006-12-01  0:38   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ejrlai5p.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox