From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14672 invoked by alias); 30 Nov 2006 00:31:44 -0000 Received: (qmail 14664 invoked by uid 22791); 30 Nov 2006 00:31:44 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 30 Nov 2006 00:31:39 +0000 Received: (qmail 11896 invoked from network); 30 Nov 2006 00:31:38 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Nov 2006 00:31:38 -0000 To: gdb-patches@sourceware.org Subject: RFA: remove redundant code in ada-lang.c From: Jim Blandy Date: Thu, 30 Nov 2006 00:31:00 -0000 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00411.txt.bz2 I don't have an Ada compiler handy, so I can't test this, but does this look right, Joel? It seems to me that since ada_value_primitive_packed_val is passed arr as its 'obj' parameter, v's lvalue type should already be set accordingly. 2006-11-22 Jim Blandy * ada-lang.c (value_subscript_packed): Don't bother to set the lvalue type of the returned value here; ada_value_primitive_packed_val takes care of that. Index: gdb-jimb-browse/gdb/ada-lang.c =================================================================== --- gdb-jimb-browse.orig/gdb/ada-lang.c 2006-11-29 14:59:32.000000000 -0800 +++ gdb-jimb-browse/gdb/ada-lang.c 2006-11-29 15:06:43.393216000 -0800 @@ -1887,10 +1887,6 @@ v = ada_value_primitive_packed_val (arr, NULL, elt_off, bit_off, bits, elt_type); - if (VALUE_LVAL (arr) == lval_internalvar) - VALUE_LVAL (v) = lval_internalvar_component; - else - VALUE_LVAL (v) = VALUE_LVAL (arr); return v; }