From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14854 invoked by alias); 1 Dec 2006 00:38:05 -0000 Received: (qmail 14729 invoked by uid 22791); 1 Dec 2006 00:37:48 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 01 Dec 2006 00:37:42 +0000 Received: (qmail 16202 invoked from network); 1 Dec 2006 00:37:40 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Dec 2006 00:37:40 -0000 To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFA: remove redundant code in ada-lang.c References: <20061201000754.GE6637@adacore.com> From: Jim Blandy Date: Fri, 01 Dec 2006 00:38:00 -0000 In-Reply-To: <20061201000754.GE6637@adacore.com> (Joel Brobecker's message of "Thu, 30 Nov 2006 16:07:54 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00001.txt.bz2 Joel Brobecker writes: >> I don't have an Ada compiler handy, so I can't test this, but does >> this look right, Joel? It seems to me that since >> ada_value_primitive_packed_val is passed arr as its 'obj' parameter, >> v's lvalue type should already be set accordingly. >> >> 2006-11-22 Jim Blandy >> >> * ada-lang.c (value_subscript_packed): Don't bother to set the >> lvalue type of the returned value here; >> ada_value_primitive_packed_val takes care of that. > > Paul Hilfinger reviewed the patch for us and said that it looked good. > I tested it on my laptop and showed no regression. Committed --- thanks!