From: Tom Tromey <tromey@redhat.com>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] "lazily" allocate the raw content of lazy values
Date: Tue, 25 Nov 2008 18:47:00 -0000 [thread overview]
Message-ID: <m3y6z7u6yo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20081125112638.GE61928@adacore.com> (Jerome Guitton's message of "Tue\, 25 Nov 2008 12\:26\:38 +0100")
>>>>> "Jerome" == Jerome Guitton <guitton@adacore.com> writes:
Jerome> The new version of the patch is in attachment, re-tested against the
Jerome> testsuite. Promoting this message to RFA now. OK to apply?
Just FYI -- I can't approve or reject it.
However, it seems sound to me.
A couple more formatting nits, sorry about that.
Jerome> + /* Actual contents of the value. Target byte-order. NULL or not valid if
Jerome> + lazy is nonzero. */
Jerome> + gdb_byte *contents;
GNU style requires 2 spaces after a ".".
Jerome> +void
Jerome> +allocate_value_contents (struct value *val)
Jerome> +{
Jerome> + if (!val->contents)
Jerome> + {
Jerome> + val->contents = (gdb_byte *) xzalloc (TYPE_LENGTH (val->enclosing_type));
Jerome> + }
No need for the braces here.
Tom
next prev parent reply other threads:[~2008-11-25 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 18:51 [RFC] " Jerome Guitton
2008-11-25 17:59 ` Tom Tromey
2008-11-25 18:00 ` Tom Tromey
2008-11-25 18:11 ` [RFA] " Jerome Guitton
2008-11-25 18:47 ` Tom Tromey [this message]
2008-11-25 21:05 ` Jerome Guitton
2008-11-26 2:03 ` Joel Brobecker
2008-11-27 2:18 ` Jerome Guitton
2008-11-27 10:05 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6z7u6yo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox