From: Jerome Guitton <guitton@adacore.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] "lazily" allocate the raw content of lazy values
Date: Thu, 27 Nov 2008 10:05:00 -0000 [thread overview]
Message-ID: <20081126162942.GL12079@adacore.com> (raw)
In-Reply-To: <20081125172307.GD3946@adacore.com>
Joel Brobecker (brobecker@adacore.com):
> > 2008-11-25 Jerome Guitton <guitton@adacore.com>
> >
> > * value.h (allocate_value_lazy): New function declaration.
> > (value_free): Remove macro, make it a function.
> > * value.c (value): Move actual content outside of the memory space
> > of the struct; add a pointer to this actual content.
> > (allocate_value_lazy, allocate_value_contents): New function.
> > (allocate_value): Reimplement using these two new functions.
> > (value_contents_raw, value_contents_all_raw): If no memory
> > has been allocated yet for the actual content, allocate it.
> > (value_contents_all): Resync with struct value's changes.
> > (value_free): New function.
> > (value_copy, value_primitive_field): Use new function
> > allocate_value_lazy to allocate lazy values.
> > (value_change_enclosing_type): Resync with struct value's changes.
> > As the value is not reallocated, remove the special handling for
> > the value chain (now obsolete).
> > * valops.c (value_at_lazy): Use new function allocate_value_lazy.
> > (value_fetch_lazy): Allocate value content. Use allocate_value_lazy
> > to allocate lazy values.
> > (value_slice): Use allocate_value_lazy to allocate lazy values.
>
> Pre-approved after the following minor nits are fixed.
Minor nits fixed, now commited.
Thank you both,
Jerome
prev parent reply other threads:[~2008-11-26 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 18:51 [RFC] " Jerome Guitton
2008-11-25 17:59 ` Tom Tromey
2008-11-25 18:00 ` Tom Tromey
2008-11-25 18:11 ` [RFA] " Jerome Guitton
2008-11-25 18:47 ` Tom Tromey
2008-11-25 21:05 ` Jerome Guitton
2008-11-26 2:03 ` Joel Brobecker
2008-11-27 2:18 ` Jerome Guitton
2008-11-27 10:05 ` Jerome Guitton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081126162942.GL12079@adacore.com \
--to=guitton@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox