From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60299-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14326 invoked by alias); 25 Nov 2008 16:06:21 -0000
Received: (qmail 14247 invoked by uid 22791); 25 Nov 2008 16:06:20 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Nov 2008 16:05:45 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAPG5MJC029708; 	Tue, 25 Nov 2008 11:05:22 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAPG5KjC032438; 	Tue, 25 Nov 2008 11:05:21 -0500
Received: from opsy.redhat.com (vpn-13-14.rdu.redhat.com [10.11.13.14]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAPG5Kfl019560; 	Tue, 25 Nov 2008 11:05:20 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 96F44378BCE; Tue, 25 Nov 2008 09:05:19 -0700 (MST)
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] "lazily" allocate the raw content of lazy values
References: <20081124144810.GA90681@adacore.com> 	<m3fxlgw5t3.fsf@fleche.redhat.com> 	<20081125112638.GE61928@adacore.com>
From: Tom Tromey <tromey@redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 25 Nov 2008 18:47:00 -0000
In-Reply-To: <20081125112638.GE61928@adacore.com> (Jerome Guitton's message of "Tue\, 25 Nov 2008 12\:26\:38 +0100")
Message-ID: <m3y6z7u6yo.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00690.txt.bz2

>>>>> "Jerome" == Jerome Guitton <guitton@adacore.com> writes:

Jerome> The new version of the patch is in attachment, re-tested against the
Jerome> testsuite. Promoting this message to RFA now. OK to apply?

Just FYI -- I can't approve or reject it.
However, it seems sound to me.

A couple more formatting nits, sorry about that.

Jerome> +  /* Actual contents of the value. Target byte-order. NULL or not valid if
Jerome> +     lazy is nonzero. */
Jerome> +  gdb_byte *contents;

GNU style requires 2 spaces after a ".".

Jerome> +void
Jerome> +allocate_value_contents (struct value *val)
Jerome> +{
Jerome> +  if (!val->contents)
Jerome> +    {
Jerome> +      val->contents = (gdb_byte *) xzalloc (TYPE_LENGTH (val->enclosing_type));
Jerome> +    }

No need for the braces here.

Tom