From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: RFA: fix PR 9164
Date: Sun, 04 Jan 2009 18:10:00 -0000 [thread overview]
Message-ID: <m3y6xrq6x6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090104032948.GA3339@caradoc.them.org> (Daniel Jacobowitz's message of "Sat\, 3 Jan 2009 22\:29\:48 -0500")
>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:
Tom> This fix defers the choice of type to the language, using the existing
Tom> language-arch machinery. I fixed the C language family, including
Tom> ObjC, but I left the other languages unchanged. I think the language
Tom> maintainers will have to make a change here, if one is needed or
Tom> desired. (FWIW I don't think Java needs a change, since I don't think
Tom> it is possible to invoke sizeof when Java is the selected language.)
Daniel> Before adding all this, do you know of any language where the signed
Daniel> behavior is correct?
Nope. I don't know that a signed type is incorrect, either. I really
know nothing about the other languages here, so I chose to preserve
the current behavior.
Even if all languages want an unsigned type, I still think something
like this patch is the way to go, because for C languages you
generally want the inferior's "size_t".
That is, this is the way to go assuming that we continue to have
language-dependent expressions. If it weren't for UNOP_SIZEOF, I
probably would have made this a C-specific patch. Another idea would
be to add an evaluate_subexp_c, and have it handle UNOP_SIZEOF.
Tom
next prev parent reply other threads:[~2009-01-04 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-03 21:20 Tom Tromey
2009-01-04 3:29 ` Daniel Jacobowitz
2009-01-04 18:10 ` Tom Tromey [this message]
2009-01-05 4:23 ` Joel Brobecker
2009-01-05 4:51 ` Tom Tromey
2009-01-05 9:23 ` Mark Kettenis
2009-01-05 9:30 ` Joel Brobecker
2009-01-05 17:29 ` Pedro Alves
2009-01-05 18:31 ` Tom Tromey
2009-01-07 22:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6xrq6x6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox