From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix PR 9164
Date: Sun, 04 Jan 2009 03:29:00 -0000 [thread overview]
Message-ID: <20090104032948.GA3339@caradoc.them.org> (raw)
In-Reply-To: <m34p0grssm.fsf@fleche.redhat.com>
On Sat, Jan 03, 2009 at 02:19:53PM -0700, Tom Tromey wrote:
> This patch fixes PR 9164.
>
> The bug is that the result of sizeof has signed type, not unsigned.
> The C and C++ standards require an unsigned type here.
>
> This fix defers the choice of type to the language, using the existing
> language-arch machinery. I fixed the C language family, including
> ObjC, but I left the other languages unchanged. I think the language
> maintainers will have to make a change here, if one is needed or
> desired. (FWIW I don't think Java needs a change, since I don't think
> it is possible to invoke sizeof when Java is the selected language.)
>
> Built and regtested on x86-64 (compile farm).
> New test case included.
Before adding all this, do you know of any language where the signed
behavior is correct?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-01-04 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-03 21:20 Tom Tromey
2009-01-04 3:29 ` Daniel Jacobowitz [this message]
2009-01-04 18:10 ` Tom Tromey
2009-01-05 4:23 ` Joel Brobecker
2009-01-05 4:51 ` Tom Tromey
2009-01-05 9:23 ` Mark Kettenis
2009-01-05 9:30 ` Joel Brobecker
2009-01-05 17:29 ` Pedro Alves
2009-01-05 18:31 ` Tom Tromey
2009-01-07 22:13 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104032948.GA3339@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox