Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: RFA: fix PR 9164
Date: Mon, 05 Jan 2009 09:23:00 -0000	[thread overview]
Message-ID: <200901050922.n059MjIo015901@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20090105042336.GE31595@adacore.com> (message from Joel Brobecker 	on Mon, 5 Jan 2009 08:23:36 +0400)

> Date: Mon, 5 Jan 2009 08:23:36 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> > Tom> This fix defers the choice of type to the language, using the existing
> > Tom> language-arch machinery.  I fixed the C language family, including
> > Tom> ObjC, but I left the other languages unchanged.  I think the language
> > Tom> maintainers will have to make a change here, if one is needed or
> > Tom> desired.  (FWIW I don't think Java needs a change, since I don't think
> > Tom> it is possible to invoke sizeof when Java is the selected language.)
> > 
> > Daniel> Before adding all this, do you know of any language where the signed
> > Daniel> behavior is correct?
> > 
> > Nope.  I don't know that a signed type is incorrect, either.  I really
> > know nothing about the other languages here, so I chose to preserve
> > the current behavior.
> 
> In Ada, the equivalent of the sizeof operator is the 'Size attribute.
> This attribute is a function that returns the size in bits and its
> type is a ``universal_integer''. universal_integer is not a type
> you can use in declarations, but it allows any integer values, so
> I think that it would be reasonable to make the 'size attribute
> return a value of Integer type (thus signed). I checked the code,
> and we actually use builtin_type_int32 (we used to use builtin_type_int
> but this type is hard to get to, now, as you need access to the gdbarch).

Well, using built_type_int32 defenitely feels wrong for a type
representing sizes on a 64-bit system.


  parent reply	other threads:[~2009-01-05  9:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-03 21:20 Tom Tromey
2009-01-04  3:29 ` Daniel Jacobowitz
2009-01-04 18:10   ` Tom Tromey
2009-01-05  4:23     ` Joel Brobecker
2009-01-05  4:51       ` Tom Tromey
2009-01-05  9:23       ` Mark Kettenis [this message]
2009-01-05  9:30         ` Joel Brobecker
2009-01-05 17:29 ` Pedro Alves
2009-01-05 18:31   ` Tom Tromey
2009-01-07 22:13     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901050922.n059MjIo015901@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox