From: Tom Tromey <tromey@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix building with system readline
Date: Mon, 22 Mar 2010 17:25:00 -0000 [thread overview]
Message-ID: <m3y6hks1z8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1268964553-30413-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Thu, 18 Mar 2010 22:09:13 -0400")
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> Building gdb with --enable-targets=all and --with-system-readline hits a
Mike> failure in a few targets all related to the inclusion of some opcodes
Mike> headers. The usage of the bundled readline results in an -I to the top
Mike> srcdir, but if that isn't used, then there is no such -I path. A few gdb
Mike> targets use this implicitly to include opcodes/ source header files. So
Mike> change the include paths to use an -I to the opcodes/ directory, and then
Mike> have the gdb files drop the opcodes/ path in the #include.
Mike> An alternative is to add -I$(top_srcdir) to the main CFLAGS ...
I personally find the #include "opcodes/whatever.h" form a little
clearer. However, I don't have very strong feelings about it.
Give this patch a couple more days; if nobody speaks up in favor of one
approach or the other, then it is ok.
thanks,
Tom
next prev parent reply other threads:[~2010-03-22 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 2:09 Mike Frysinger
2010-03-22 17:25 ` Tom Tromey [this message]
2010-03-22 17:39 ` Joel Brobecker
2010-03-22 19:33 ` Mike Frysinger
2010-03-23 4:48 ` [PATCH v2] " Mike Frysinger
2010-03-23 16:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6hks1z8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox