From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5815 invoked by alias); 22 Mar 2010 17:25:30 -0000 Received: (qmail 5805 invoked by uid 22791); 22 Mar 2010 17:25:29 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Mar 2010 17:25:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2MHPJH2028927 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 22 Mar 2010 13:25:20 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2MHPJmA017195; Mon, 22 Mar 2010 13:25:19 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2MHPI0p021671; Mon, 22 Mar 2010 13:25:18 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 047B7379846; Mon, 22 Mar 2010 11:25:17 -0600 (MDT) From: Tom Tromey To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: fix building with system readline References: <1268964553-30413-1-git-send-email-vapier@gentoo.org> Reply-To: tromey@redhat.com Date: Mon, 22 Mar 2010 17:25:00 -0000 In-Reply-To: <1268964553-30413-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Thu, 18 Mar 2010 22:09:13 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00762.txt.bz2 >>>>> "Mike" == Mike Frysinger writes: Mike> Building gdb with --enable-targets=all and --with-system-readline hits a Mike> failure in a few targets all related to the inclusion of some opcodes Mike> headers. The usage of the bundled readline results in an -I to the top Mike> srcdir, but if that isn't used, then there is no such -I path. A few gdb Mike> targets use this implicitly to include opcodes/ source header files. So Mike> change the include paths to use an -I to the opcodes/ directory, and then Mike> have the gdb files drop the opcodes/ path in the #include. Mike> An alternative is to add -I$(top_srcdir) to the main CFLAGS ... I personally find the #include "opcodes/whatever.h" form a little clearer. However, I don't have very strong feelings about it. Give this patch a couple more days; if nobody speaks up in favor of one approach or the other, then it is ok. thanks, Tom