From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix building with system readline
Date: Mon, 22 Mar 2010 19:33:00 -0000 [thread overview]
Message-ID: <201003221533.16263.vapier@gentoo.org> (raw)
In-Reply-To: <20100322173846.GG2844@adacore.com>
[-- Attachment #1: Type: Text/Plain, Size: 574 bytes --]
On Monday 22 March 2010 13:38:46 Joel Brobecker wrote:
> > I personally find the #include "opcodes/whatever.h" form a little
> > clearer. However, I don't have very strong feelings about it.
>
> So do I, actually. I had it on my list to see if there was a way
> around doing that (there may be an obvious way, I have just had
> time to skim the patch when it came in).
i could simply add -I$(top_srcdir) to OPCODES_CFLAGS and a small comment
explaining why. i went the opcodes/ path because that's the patch i happened
to already have laying around.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-03-22 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 2:09 Mike Frysinger
2010-03-22 17:25 ` Tom Tromey
2010-03-22 17:39 ` Joel Brobecker
2010-03-22 19:33 ` Mike Frysinger [this message]
2010-03-23 4:48 ` [PATCH v2] " Mike Frysinger
2010-03-23 16:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003221533.16263.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox