From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 690 invoked by alias); 22 Mar 2010 19:33:28 -0000 Received: (qmail 677 invoked by uid 22791); 22 Mar 2010 19:33:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Mar 2010 19:33:20 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 179F71B400B; Mon, 22 Mar 2010 19:33:18 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: [PATCH] gdb: fix building with system readline Date: Mon, 22 Mar 2010 19:33:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.1; KDE/4.4.1; x86_64; ; ) Cc: Tom Tromey , gdb-patches@sourceware.org References: <1268964553-30413-1-git-send-email-vapier@gentoo.org> <20100322173846.GG2844@adacore.com> In-Reply-To: <20100322173846.GG2844@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2398824.7W1EK32E6v"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003221533.16263.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00772.txt.bz2 --nextPart2398824.7W1EK32E6v Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 570 On Monday 22 March 2010 13:38:46 Joel Brobecker wrote: > > I personally find the #include "opcodes/whatever.h" form a little > > clearer. However, I don't have very strong feelings about it. >=20 > So do I, actually. I had it on my list to see if there was a way > around doing that (there may be an obvious way, I have just had > time to skim the patch when it came in). i could simply add -I$(top_srcdir) to OPCODES_CFLAGS and a small comment=20 explaining why. i went the opcodes/ path because that's the patch i happen= ed=20 to already have laying around. -mike --nextPart2398824.7W1EK32E6v Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLp8X8AAoJEEFjO5/oN/WBYogP/RGN8lbf+8FF7Z6AaeBc3WFx EyU809Wb6jrVi83mn8BA5zmOqF+y+zTBy/i1sVnDgeDYLFR2p5JPppXND7IY4+W8 GHcT35JwPaL4gXaaqklFKBCzMnKy6hreOxe3A+rU4NRubMK4OAcrL5M2O0JJbkDw I1Amh3HtzNXmlv72AhqaTitAy1vhijYpdfbgs4xe7BxWIu8/esmd+QqPkEeKrc3V Y07wM99xcc0QcxX6uY5dmWsecg8lkenZS68oTxndOnPHlcWPaddT1f+3tqPhOn7+ iftSVYEG3H7THEsRAhoKttwrCcmQqO1hfSzFvLolwSLfIzl53ryw4WZuzlk/JRH/ x/hIM1hBSjIdkDLPEv8oWTr/hkO70kYmh91Jx/v++AZRdJrgsKMD/OIVs1cj4rZD X76D66+vv/npfyU0nf/r/0WTCoFCNWLJ/k4m7VcgCkMFa82FL67ugiPWzlAlW8Tl 6qb/NMtzC1Go2YDFIeYXAoUSh9kZSJhrkgPIR+nUiqAwJNpARpAUniGRlTeFZESk 9g/icfBEnUiqJIXxlWSegGyRrie8rBDAqLSOqrkFeumJf0HZXw6JKVTzGgKlfZc1 Jv1t7kwNrKv5rUmPGtpiUUO3pG04APZPsvWTsUYt3f3s4jdvCp3L/avJEHTeL0XU r13OZhWv+dk9sUYwq5Id =4pzT -----END PGP SIGNATURE----- --nextPart2398824.7W1EK32E6v--