Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] DW_OP_call: Provide per_cu in the batons
Date: Mon, 07 Jun 2010 17:44:00 -0000	[thread overview]
Message-ID: <m3y6eqn3fg.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100607115641.GB24148@host0.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Mon, 7 Jun 2010 13:56:42 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> provide per_cu in the batons as required by the patch 2/2.

Jan> 2010-06-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	* dwarf2loc.c (struct dwarf_expr_baton) Replace objfile by per_cu.
Jan> 	(dwarf_expr_tls_address): Use per_cu instead of objfile.
Jan> 	(dwarf2_evaluate_loc_desc): Drop initialization of BATON.OBJFILE.
Jan> 	Initialize new BATON.PER_CU.  Adjust CTX->GDBARCH initialization for
Jan> 	this change.
Jan> 	(struct needs_frame_baton): New field per_cu.
Jan> 	(dwarf2_loc_desc_needs_frame): Initialize new BATON.PER_CU.
Jan> 	* dwarf2read.c (struct dwarf2_per_cu_data) <cu>: Extend the comment.

Ok with one nit fixed:

Jan> +  /* Set no non-NULL iff this CU is currently loaded.  When it gets freed out

s/no/to/

thanks,
Tom


  reply	other threads:[~2010-06-07 17:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-20 12:37 [patch] Support DW_OP_call2 and DW_OP_call4 (PR 10640) Jan Kratochvil
2009-10-12 20:43 ` Tom Tromey
2009-10-12 20:49   ` Tom Tromey
2010-06-07 11:56     ` [patch 2/2] DW_OP_call: Support DW_OP_call2 and DW_OP_call4 Jan Kratochvil
2010-06-07 18:13       ` Tom Tromey
2010-06-07 20:00         ` Jan Kratochvil
2010-06-07 11:56     ` [patch 0/2] DW_OP_call: Re: [patch] Support DW_OP_call2 and DW_OP_call4 (PR 10640) Jan Kratochvil
2010-06-07 11:56     ` [patch 1/2] DW_OP_call: Provide per_cu in the batons Jan Kratochvil
2010-06-07 17:44       ` Tom Tromey [this message]
2010-06-07 19:44         ` Jan Kratochvil
2009-10-12 21:08   ` [patch] Support DW_OP_call2 and DW_OP_call4 (PR 10640) Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y6eqn3fg.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox