From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6627 invoked by alias); 7 Jun 2010 17:44:16 -0000 Received: (qmail 6612 invoked by uid 22791); 7 Jun 2010 17:44:14 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Jun 2010 17:44:07 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o57Hi5gJ021436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 Jun 2010 13:44:05 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o57Hi57n026678; Mon, 7 Jun 2010 13:44:05 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o57Hi4Da014209; Mon, 7 Jun 2010 13:44:04 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3134A3782A3; Mon, 7 Jun 2010 11:44:03 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/2] DW_OP_call: Provide per_cu in the batons References: <20100607115641.GB24148@host0.dyn.jankratochvil.net> Reply-To: Tom Tromey Date: Mon, 07 Jun 2010 17:44:00 -0000 In-Reply-To: <20100607115641.GB24148@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Mon, 7 Jun 2010 13:56:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00177.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> provide per_cu in the batons as required by the patch 2/2. Jan> 2010-06-07 Jan Kratochvil Jan> * dwarf2loc.c (struct dwarf_expr_baton) Replace objfile by per_cu. Jan> (dwarf_expr_tls_address): Use per_cu instead of objfile. Jan> (dwarf2_evaluate_loc_desc): Drop initialization of BATON.OBJFILE. Jan> Initialize new BATON.PER_CU. Adjust CTX->GDBARCH initialization for Jan> this change. Jan> (struct needs_frame_baton): New field per_cu. Jan> (dwarf2_loc_desc_needs_frame): Initialize new BATON.PER_CU. Jan> * dwarf2read.c (struct dwarf2_per_cu_data) : Extend the comment. Ok with one nit fixed: Jan> + /* Set no non-NULL iff this CU is currently loaded. When it gets freed out s/no/to/ thanks, Tom