[patch 0/2] DW_OP_call: Re: [patch] Support DW_OP_call2 and DW_OP_call4 (PR 10640)

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Mon, 12 Oct 2009 22:49:23 +0200, Tom Tromey wrote:
> Jan> as GCC discusses its use in PR41343 the patch implements it for GDB.
> 
> Also, I forgot to ask -- why not DW_OP_call_ref as well?

DW_OP_call_ref currently was not requested and it may get more tricky due to
inter-CU references.


On Mon, 12 Oct 2009 23:08:44 +0200, Daniel Jacobowitz wrote:
> I'm confused as to why the "struct symbol" comes into this though.
> We're just using it to look up its DWARF location again.  Can we do
> this directly off the target DIE?  We don't free up the loaded
> .debug_info (partly to support DW_FORM_string).

I was not aware the DIEs are being held allocated for read-in CU.  Fixed the
comment there.


> And we have infrastructure to load a given CU's dies whenever we need them.

It should not be needed when only DW_OP_call{2,4} and not DW_OP_call_ref are
supported.


No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu.

OK to check-in?


Thanks,
Jan