From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26944 invoked by alias); 7 Jun 2010 11:56:48 -0000 Received: (qmail 26931 invoked by uid 22791); 7 Jun 2010 11:56:47 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Jun 2010 11:56:42 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o57BufCj018495 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 Jun 2010 07:56:41 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o57BubIa012243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Jun 2010 07:56:39 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o57BubE8004796; Mon, 7 Jun 2010 13:56:37 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o57BuaM4004795; Mon, 7 Jun 2010 13:56:36 +0200 Date: Mon, 07 Jun 2010 11:56:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: [patch 0/2] DW_OP_call: Re: [patch] Support DW_OP_call2 and DW_OP_call4 (PR 10640) Message-ID: <20100607115636.GA24148@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091012210844.GA20340@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00169.txt.bz2 On Mon, 12 Oct 2009 22:49:23 +0200, Tom Tromey wrote: > Jan> as GCC discusses its use in PR41343 the patch implements it for GDB. > > Also, I forgot to ask -- why not DW_OP_call_ref as well? DW_OP_call_ref currently was not requested and it may get more tricky due to inter-CU references. On Mon, 12 Oct 2009 23:08:44 +0200, Daniel Jacobowitz wrote: > I'm confused as to why the "struct symbol" comes into this though. > We're just using it to look up its DWARF location again. Can we do > this directly off the target DIE? We don't free up the loaded > .debug_info (partly to support DW_FORM_string). I was not aware the DIEs are being held allocated for read-in CU. Fixed the comment there. > And we have infrastructure to load a given CU's dies whenever we need them. It should not be needed when only DW_OP_call{2,4} and not DW_OP_call_ref are supported. No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu. OK to check-in? Thanks, Jan