From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver)
Date: Wed, 02 Oct 2013 21:02:00 -0000 [thread overview]
Message-ID: <m3y56b1j4g.fsf@redhat.com> (raw)
In-Reply-To: <m34n91606g.fsf@redhat.com> (Sergio Durigan Junior's message of "Tue, 01 Oct 2013 02:16:07 -0300")
On Tuesday, October 01 2013, I wrote:
>> ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * NEWS: Document new QcatchSyscalls packet and its use
>> in x86/amd64 linux gdbserver and Valgrind gdbserver.
>> * remote.c (PACKET_QCatchSyscalls): New.
>> (remote_protocol_features): Add QcatchSyscalls.
>> (remote_set_syscall_catchpoint): New function.
>> (remote_parse_stop_reply): New stop reasons syscall_entry
>> and syscall_return.
>> (init_remote_ops): Registers remote_set_syscall_catchpoint
>> and the config commands for PACKET_QCatchSyscalls.
>> * common/linux-ptrace.c (linux_check_ptrace_features):
>> Detect PTRACE_O_TRACESYSGOOD for gdbserver.
>> (ptrace_supports_feature): Initializes ptrace features if needed.
>>
>> doc/ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * gdb.texinfo (General Query Packets): Document new QCatchSyscalls
>> packet.
>> (Stop Reply Packets): Document new stop reasons syscall_entry and
>> syscall_return.
>> (Async Records): Fixed syscall-return item name.
>>
>> gdbserver/ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * target.h (struct target_ops): Add supports_catch_syscall operation.
>> * linux-low.h (struct linux_target_ops): Add get_syscall_trapinfo
>> operation.
>> * linux-low.c (linux_wait_1): Enable, detect and handle
>> SYSCALL_SIGTRAP.
>> (gdb_catch_this_syscall_p): New function.
>> (get_syscall_trapinfo): New function.
>> (linux_supports_catch_syscall): New function.
>> (struct target_ops linux_target_ops): Set linux_supports_catch_syscall.
>> * linux-x86-low.c (x86_get_syscall_trapinfo): New function.
>> (struct linux_target_ops the_low_target): Set x86_get_syscall_trapinfo.
>> * remote-utils.c (prepare_resume_reply): Handle status kinds
>> TARGET_WAITKIND_SYSCALL_ENTRY and TARGET_WAITKIND_SYSCALL_RETURN.
>> * server.h: Declare catching_syscalls_p, syscalls_to_catch_size and
>> syscalls_to_catch.
>> * server.c: Define catching_syscalls_p, syscalls_to_catch_size and
>> syscalls_to_catch.
>> (handle_general_set): Handle QCatchSyscalls packet.
>> (handle_query): Reports if low target supports QCatchSyscalls.
>> * win32-low.c (struct target_ops win32_target_op): Sets NULL
>> for supports_catch_syscall.
>>
>> testsuite/ChangeLog
>> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>>
>> * gdb.base/catch-syscall.exp: Enables test for x86 and amd64
>> gdbserver.
>>
BTW, I totally forgot about it, but you should take ownership of PR
remote/13585, mention it in the ChangeLog entries, and close it when the
patch is committed.
Thanks!
--
Sergio
next prev parent reply other threads:[~2013-10-02 21:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 20:55 RFA [PATCH v3] Implement 'catch syscall' for gdbserver Philippe Waroquiers
2013-09-21 21:03 ` Eli Zaretskii
2013-09-23 11:51 ` Agovic, Sanimir
2013-09-23 19:32 ` Philippe Waroquiers
2013-09-24 7:07 ` Agovic, Sanimir
2013-09-25 16:55 ` Sergio Durigan Junior
2013-09-25 22:55 ` Philippe Waroquiers
2013-09-27 13:25 ` [COMMIT PATCH] remote.c: Remove unnecessary fields from 'struct stop_reply'. (was: Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) Pedro Alves
2013-09-27 19:30 ` RFA [PATCH v3] Implement 'catch syscall' for gdbserver Pedro Alves
2013-09-27 20:13 ` Philippe Waroquiers
2013-09-27 20:55 ` Sergio Durigan Junior
2013-09-29 15:04 ` RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) Philippe Waroquiers
2013-10-01 5:16 ` Sergio Durigan Junior
2013-10-02 21:02 ` Sergio Durigan Junior [this message]
2013-10-02 19:41 ` Always run the PTRACE_O_TRACESYSGOOD tests even if PTRACE_O_TRACEFORK is not supported. (was: Re: RFA [PATCH v4] " Pedro Alves
2013-10-02 22:08 ` Philippe Waroquiers
2013-10-03 10:16 ` Always run the PTRACE_O_TRACESYSGOOD tests even if PTRACE_O_TRACEFORK is not supported Pedro Alves
2013-10-03 18:40 ` RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) Pedro Alves
2013-10-03 19:53 ` Tom Tromey
2013-10-04 17:41 ` Pedro Alves
2013-10-03 22:02 ` Philippe Waroquiers
2013-10-04 17:29 ` Pedro Alves
2013-10-05 9:15 ` Pedro Alves
2013-10-09 21:54 ` Philippe Waroquiers
2013-10-09 22:05 ` Sergio Durigan Junior
2013-10-09 22:09 ` Philippe Waroquiers
2013-10-04 4:22 ` Luis Machado
2013-10-04 17:40 ` Pedro Alves
2013-10-04 18:55 ` Stan Shebs
2013-10-07 19:07 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y56b1j4g.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox