From: Luis Machado <lgustavo@codesourcery.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver)
Date: Fri, 04 Oct 2013 04:22:00 -0000 [thread overview]
Message-ID: <524E428B.4010508@codesourcery.com> (raw)
In-Reply-To: <1380467062.3567.52.camel@soleil>
On 09/29/2013 12:04 PM, Philippe Waroquiers wrote:
> ChangeLog
> 2013-xx-yy Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> * NEWS: Document new QcatchSyscalls packet and its use
> in x86/amd64 linux gdbserver and Valgrind gdbserver.
> * remote.c (PACKET_QCatchSyscalls): New.
> (remote_protocol_features): Add QcatchSyscalls.
> (remote_set_syscall_catchpoint): New function.
> (remote_parse_stop_reply): New stop reasons syscall_entry
> and syscall_return.
> (init_remote_ops): Registers remote_set_syscall_catchpoint
> and the config commands for PACKET_QCatchSyscalls.
I'm late to the party, but i've always wondered why we have all these
different "insert_<foo>_catchpoint" and "remove_<foo>_catchpoint"
functions to accomplish tasks that seem to be very similar in nature.
Not saying we should go this route for this patch, but we may want to
consider a more generic RSP packet for catchpoints. Something like the
following:
QInsertCatchpoint:[syscall|fork|exec|vfork|unload|...]
QRemoveCatchpoint:[syscall|fork|exec|vfork|unload|...]
... or even communicate catchpoints through Z/z packets, though that
would be a more radical approach.
Anyway, just throwing a few ideas since i've been dealing with some of
the issues with catchpoints, forking and gdbserver as well.
next prev parent reply other threads:[~2013-10-04 4:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 20:55 RFA [PATCH v3] Implement 'catch syscall' for gdbserver Philippe Waroquiers
2013-09-21 21:03 ` Eli Zaretskii
2013-09-23 11:51 ` Agovic, Sanimir
2013-09-23 19:32 ` Philippe Waroquiers
2013-09-24 7:07 ` Agovic, Sanimir
2013-09-25 16:55 ` Sergio Durigan Junior
2013-09-25 22:55 ` Philippe Waroquiers
2013-09-27 13:25 ` [COMMIT PATCH] remote.c: Remove unnecessary fields from 'struct stop_reply'. (was: Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) Pedro Alves
2013-09-27 19:30 ` RFA [PATCH v3] Implement 'catch syscall' for gdbserver Pedro Alves
2013-09-27 20:13 ` Philippe Waroquiers
2013-09-27 20:55 ` Sergio Durigan Junior
2013-09-29 15:04 ` RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) Philippe Waroquiers
2013-10-01 5:16 ` Sergio Durigan Junior
2013-10-02 21:02 ` Sergio Durigan Junior
2013-10-02 19:41 ` Always run the PTRACE_O_TRACESYSGOOD tests even if PTRACE_O_TRACEFORK is not supported. (was: Re: RFA [PATCH v4] " Pedro Alves
2013-10-02 22:08 ` Philippe Waroquiers
2013-10-03 10:16 ` Always run the PTRACE_O_TRACESYSGOOD tests even if PTRACE_O_TRACEFORK is not supported Pedro Alves
2013-10-03 18:40 ` RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) Pedro Alves
2013-10-03 19:53 ` Tom Tromey
2013-10-04 17:41 ` Pedro Alves
2013-10-03 22:02 ` Philippe Waroquiers
2013-10-04 17:29 ` Pedro Alves
2013-10-05 9:15 ` Pedro Alves
2013-10-09 21:54 ` Philippe Waroquiers
2013-10-09 22:05 ` Sergio Durigan Junior
2013-10-09 22:09 ` Philippe Waroquiers
2013-10-04 4:22 ` Luis Machado [this message]
2013-10-04 17:40 ` Pedro Alves
2013-10-04 18:55 ` Stan Shebs
2013-10-07 19:07 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524E428B.4010508@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=philippe.waroquiers@skynet.be \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox