From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14880 invoked by alias); 4 Oct 2013 04:22:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14863 invoked by uid 89); 4 Oct 2013 04:22:51 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Oct 2013 04:22:51 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VRwuc-0003c6-2M from Luis_Gustavo@mentor.com ; Thu, 03 Oct 2013 21:22:46 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 3 Oct 2013 21:22:45 -0700 Received: from [172.30.8.118] ([172.30.8.118]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 3 Oct 2013 21:22:45 -0700 Message-ID: <524E428B.4010508@codesourcery.com> Date: Fri, 04 Oct 2013 04:22:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Philippe Waroquiers , Sergio Durigan Junior CC: gdb-patches@sourceware.org, Pedro Alves Subject: Re: RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) References: <1379796907.5980.20.camel@soleil> <1380467062.3567.52.camel@soleil> In-Reply-To: <1380467062.3567.52.camel@soleil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00125.txt.bz2 On 09/29/2013 12:04 PM, Philippe Waroquiers wrote: > ChangeLog > 2013-xx-yy Philippe Waroquiers > > * NEWS: Document new QcatchSyscalls packet and its use > in x86/amd64 linux gdbserver and Valgrind gdbserver. > * remote.c (PACKET_QCatchSyscalls): New. > (remote_protocol_features): Add QcatchSyscalls. > (remote_set_syscall_catchpoint): New function. > (remote_parse_stop_reply): New stop reasons syscall_entry > and syscall_return. > (init_remote_ops): Registers remote_set_syscall_catchpoint > and the config commands for PACKET_QCatchSyscalls. I'm late to the party, but i've always wondered why we have all these different "insert__catchpoint" and "remove__catchpoint" functions to accomplish tasks that seem to be very similar in nature. Not saying we should go this route for this patch, but we may want to consider a more generic RSP packet for catchpoints. Something like the following: QInsertCatchpoint:[syscall|fork|exec|vfork|unload|...] QRemoveCatchpoint:[syscall|fork|exec|vfork|unload|...] ... or even communicate catchpoints through Z/z packets, though that would be a more radical approach. Anyway, just throwing a few ideas since i've been dealing with some of the issues with catchpoints, forking and gdbserver as well.