From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14034 invoked by alias); 2 Oct 2013 21:02:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14016 invoked by uid 89); 2 Oct 2013 21:02:49 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Oct 2013 21:02:49 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r92L2hVi007867 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Oct 2013 17:02:44 -0400 Received: from psique (ovpn-113-79.phx2.redhat.com [10.3.113.79]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r92L2eNS024024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 2 Oct 2013 17:02:42 -0400 From: Sergio Durigan Junior To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: RFA [PATCH v4] Implement 'catch syscall' for gdbserver (was Re: RFA [PATCH v3] Implement 'catch syscall' for gdbserver) References: <1379796907.5980.20.camel@soleil> <1380467062.3567.52.camel@soleil> X-URL: http://www.redhat.com Date: Wed, 02 Oct 2013 21:02:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Tue, 01 Oct 2013 02:16:07 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00109.txt.bz2 On Tuesday, October 01 2013, I wrote: >> ChangeLog >> 2013-xx-yy Philippe Waroquiers >> >> * NEWS: Document new QcatchSyscalls packet and its use >> in x86/amd64 linux gdbserver and Valgrind gdbserver. >> * remote.c (PACKET_QCatchSyscalls): New. >> (remote_protocol_features): Add QcatchSyscalls. >> (remote_set_syscall_catchpoint): New function. >> (remote_parse_stop_reply): New stop reasons syscall_entry >> and syscall_return. >> (init_remote_ops): Registers remote_set_syscall_catchpoint >> and the config commands for PACKET_QCatchSyscalls. >> * common/linux-ptrace.c (linux_check_ptrace_features): >> Detect PTRACE_O_TRACESYSGOOD for gdbserver. >> (ptrace_supports_feature): Initializes ptrace features if needed. >> >> doc/ChangeLog >> 2013-xx-yy Philippe Waroquiers >> >> * gdb.texinfo (General Query Packets): Document new QCatchSyscalls >> packet. >> (Stop Reply Packets): Document new stop reasons syscall_entry and >> syscall_return. >> (Async Records): Fixed syscall-return item name. >> >> gdbserver/ChangeLog >> 2013-xx-yy Philippe Waroquiers >> >> * target.h (struct target_ops): Add supports_catch_syscall operation. >> * linux-low.h (struct linux_target_ops): Add get_syscall_trapinfo >> operation. >> * linux-low.c (linux_wait_1): Enable, detect and handle >> SYSCALL_SIGTRAP. >> (gdb_catch_this_syscall_p): New function. >> (get_syscall_trapinfo): New function. >> (linux_supports_catch_syscall): New function. >> (struct target_ops linux_target_ops): Set linux_supports_catch_syscall. >> * linux-x86-low.c (x86_get_syscall_trapinfo): New function. >> (struct linux_target_ops the_low_target): Set x86_get_syscall_trapinfo. >> * remote-utils.c (prepare_resume_reply): Handle status kinds >> TARGET_WAITKIND_SYSCALL_ENTRY and TARGET_WAITKIND_SYSCALL_RETURN. >> * server.h: Declare catching_syscalls_p, syscalls_to_catch_size and >> syscalls_to_catch. >> * server.c: Define catching_syscalls_p, syscalls_to_catch_size and >> syscalls_to_catch. >> (handle_general_set): Handle QCatchSyscalls packet. >> (handle_query): Reports if low target supports QCatchSyscalls. >> * win32-low.c (struct target_ops win32_target_op): Sets NULL >> for supports_catch_syscall. >> >> testsuite/ChangeLog >> 2013-xx-yy Philippe Waroquiers >> >> * gdb.base/catch-syscall.exp: Enables test for x86 and amd64 >> gdbserver. >> BTW, I totally forgot about it, but you should take ownership of PR remote/13585, mention it in the ChangeLog entries, and close it when the patch is committed. Thanks! -- Sergio