Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] dwarf2_physname FINAL
Date: Fri, 05 Mar 2010 21:54:00 -0000	[thread overview]
Message-ID: <m3wrxqsadk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B903926.7070303@redhat.com> (Keith Seitz's message of "Thu, 04 	Mar 2010 14:50:14 -0800")

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Okay, now that 7.1 has branch, it is time to give the go/no-go on this
Keith> patch. I'm attaching the "final" version (in full this time, in case
Keith> anyone wants to apply it to their own sandbox).

Keith> The only "new" stuff in this patch is a fixlet to py-symbol.exp, in
Keith> which a test prints out the linkage name (which has obviously
Keith> changed).

Given the earlier approvals, I think this is ok.  Please check it in.
If there are lingering problems, we can fix them.

Keith> One other issue that I uncovered: DW_AT_MIPS_linkage_name appears to
Keith> be necessary for Ada. I have a patch that I used to address this (for
Keith> one of our internal releases), but it is probably not complete. [In
Keith> other words: it's now just as broken as it was before.] I can submit
Keith> this as a follow-up, if so desired.

By this, I assume you mean that after your patch, Ada continues to work,
but still uses DW_AT_MIPS_linkage_name; and that you have a follow-on
patch that is incomplete but which attempts to remove the reliance on
DW_AT_MIPS_linkage_name?

thanks,
Tom


  reply	other threads:[~2010-03-05 21:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 22:52 Keith Seitz
2010-03-05 21:54 ` Tom Tromey [this message]
2010-03-05 22:12   ` Keith Seitz
2010-03-08  6:18 ` Joel Brobecker
2010-03-09 18:10   ` Keith Seitz
2010-03-10  8:11     ` [commit/dwarf2/Ada] Adjust handling of Ada DIEs after dwarf2_physname patch Joel Brobecker
2010-03-23 20:25 ` [RFA] dwarf2_physname FINAL Ulrich Weigand
2010-03-24 20:24   ` Keith Seitz
2010-03-25 10:21     ` Ulrich Weigand
2010-03-25 18:31       ` [RFA] Java DWARF fixes (was Re: [RFA] dwarf2_physname FINAL) Keith Seitz
2010-03-25 20:05         ` [RFA] Java DWARF fixes Tom Tromey
2010-03-25 22:14           ` Keith Seitz
2010-03-26 16:48             ` Ulrich Weigand
2010-03-26 16:54               ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wrxqsadk.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox