Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: keiths@redhat.com (Keith Seitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Java DWARF fixes
Date: Fri, 26 Mar 2010 16:48:00 -0000	[thread overview]
Message-ID: <201003261648.o2QGm440019919@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <4BABE023.9070102@redhat.com> from "Keith Seitz" at Mar 25, 2010 03:13:55 PM

Keith Seitz wrote:
> On 03/25/2010 01:05 PM, Tom Tromey wrote:
> > This all seems pretty reasonable to me.  It is ok.
> 
> I have committed the patches. Thank you for reviewing them.

Thanks!  Unfortunately, the test case still fails for me:
FAIL: gdb.java/jmisc.exp: ptype jmisc

This time the problem seems to be that the constructor
is shown with a "void" argument list:

type = class jmisc  extends java.lang.Object {

    void main(java.lang.String[])void;
    jmisc(void)void;
}

while the test expects this to be just "jmisc()":

    send_gdb "ptype jmisc\n"
    gdb_expect {
        -re "type = class jmisc  extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $"
            { pass "ptype jmisc" }
        -re "type = class jmisc  extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\)void;\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" {
            # Just because GCC includes the signature doesn't mean we
            # should print it here.  We already show the return type.
            kfail "ptype jmisc" gdb/2215
        }
        -re ".*$gdb_prompt $"             { fail "ptype jmisc" }
        timeout { fail "ptype jmisc (timeout)" ; return }
    }

Is this a testcase problem or still something wrong in
the symbol reader?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2010-03-26 16:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 22:52 [RFA] dwarf2_physname FINAL Keith Seitz
2010-03-05 21:54 ` Tom Tromey
2010-03-05 22:12   ` Keith Seitz
2010-03-08  6:18 ` Joel Brobecker
2010-03-09 18:10   ` Keith Seitz
2010-03-10  8:11     ` [commit/dwarf2/Ada] Adjust handling of Ada DIEs after dwarf2_physname patch Joel Brobecker
2010-03-23 20:25 ` [RFA] dwarf2_physname FINAL Ulrich Weigand
2010-03-24 20:24   ` Keith Seitz
2010-03-25 10:21     ` Ulrich Weigand
2010-03-25 18:31       ` [RFA] Java DWARF fixes (was Re: [RFA] dwarf2_physname FINAL) Keith Seitz
2010-03-25 20:05         ` [RFA] Java DWARF fixes Tom Tromey
2010-03-25 22:14           ` Keith Seitz
2010-03-26 16:48             ` Ulrich Weigand [this message]
2010-03-26 16:54               ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003261648.o2QGm440019919@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox