From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18108 invoked by alias); 5 Mar 2010 21:54:09 -0000 Received: (qmail 18096 invoked by uid 22791); 5 Mar 2010 21:54:07 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Mar 2010 21:54:03 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o25Ls1pT021604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 5 Mar 2010 16:54:01 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o25Ls0Ji028405; Fri, 5 Mar 2010 16:54:01 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o25Ls0Rc016696; Fri, 5 Mar 2010 16:54:00 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id BFFC7378261; Fri, 5 Mar 2010 14:53:59 -0700 (MST) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] dwarf2_physname FINAL References: <4B903926.7070303@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 05 Mar 2010 21:54:00 -0000 In-Reply-To: <4B903926.7070303@redhat.com> (Keith Seitz's message of "Thu, 04 Mar 2010 14:50:14 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00246.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> Okay, now that 7.1 has branch, it is time to give the go/no-go on this Keith> patch. I'm attaching the "final" version (in full this time, in case Keith> anyone wants to apply it to their own sandbox). Keith> The only "new" stuff in this patch is a fixlet to py-symbol.exp, in Keith> which a test prints out the linkage name (which has obviously Keith> changed). Given the earlier approvals, I think this is ok. Please check it in. If there are lingering problems, we can fix them. Keith> One other issue that I uncovered: DW_AT_MIPS_linkage_name appears to Keith> be necessary for Ada. I have a patch that I used to address this (for Keith> one of our internal releases), but it is probably not complete. [In Keith> other words: it's now just as broken as it was before.] I can submit Keith> this as a follow-up, if so desired. By this, I assume you mean that after your patch, Ada continues to work, but still uses DW_AT_MIPS_linkage_name; and that you have a follow-on patch that is incomplete but which attempts to remove the reliance on DW_AT_MIPS_linkage_name? thanks, Tom